Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new mobile_app webhook command: get_zones #22604

Merged
merged 2 commits into from Apr 1, 2019

Conversation

@robbiet480
Copy link
Member

commented Mar 31, 2019

Description:

Adds a new mobile_app webhook command, get_zones, which just returns all zones.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@robbiet480 robbiet480 requested a review from home-assistant/core as a code owner Mar 31, 2019

@ghost ghost assigned robbiet480 Mar 31, 2019

@ghost ghost added the in progress label Mar 31, 2019

@balloob

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Tests?

@balloob

balloob approved these changes Apr 1, 2019

Copy link
Member

left a comment

ok to merge when tests added

@robbiet480

This comment has been minimized.

Copy link
Member Author

commented Apr 1, 2019

Tests added

@robbiet480 robbiet480 merged commit 7bd8c0d into dev Apr 1, 2019

12 of 14 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Hound No violations found. Woof!
build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA

@ghost ghost removed the in progress label Apr 1, 2019

@delete-merged-branch delete-merged-branch bot deleted the mobile_app-expose-zones branch Apr 1, 2019

@robbiet480

This comment has been minimized.

Copy link
Member Author

commented Apr 7, 2019

@balloob Seems this didn't make it into 0.91.2 if my users + lack of mention in release notes are to be believed. Mind getting this into 0.91.2?

@robbiet480 robbiet480 added this to the 0.91.2 milestone Apr 7, 2019

unibeck pushed a commit to unibeck/home-assistant that referenced this pull request Apr 7, 2019

Add new mobile_app webhook command: get_zones (home-assistant#22604)
## Description:

Adds a new `mobile_app` webhook command, `get_zones`, which just returns all zones.

## Checklist:
  - [x] The code change is tested and works locally.
  - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**
  - [x] There is no commented out code in this PR.

pvizeli added a commit that referenced this pull request Apr 8, 2019

Add new mobile_app webhook command: get_zones (#22604)
## Description:

Adds a new `mobile_app` webhook command, `get_zones`, which just returns all zones.

## Checklist:
  - [x] The code change is tested and works locally.
  - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**
  - [x] There is no commented out code in this PR.

@pvizeli pvizeli referenced this pull request Apr 8, 2019

Merged

0.91.2 #22883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.