Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source selection to Samsung TV media player #22612

Merged
merged 10 commits into from Jun 17, 2019

Conversation

@escoand
Copy link
Contributor

commented Apr 1, 2019

Breaking Change:

nothing

Description:

add select_source capabilities

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

media_player:
  - platform: samsungtv
    host: 192.168.0.10

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] New dependencies have been added to the REQUIREMENTS variable (example).
  • [ ] New dependencies are only imported inside functions that use them (example).
  • [ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • [ ] New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
escoand added 8 commits Apr 1, 2019

@fabaff fabaff changed the title media_player.samsungtv: add source selection Add source selection to Samsung TV media player Apr 4, 2019

Simplify source list
Co-Authored-By: escoand <escoand@users.noreply.github.com>
@escoand

This comment has been minimized.

Copy link
Contributor Author

commented Apr 28, 2019

Is there something to complain about?

@balloob balloob merged commit 7300888 into home-assistant:dev Jun 17, 2019

11 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
@balloob balloob referenced this pull request Jun 26, 2019
@earth08

This comment has been minimized.

Copy link

commented Jun 28, 2019

i tried this on 0.95
and it does shows 2 options under sources
TV
HDMI
please include to add sources in medai.yaml config to specify available sources.
I would be great.
Thanks

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Jun 28, 2019

@escoand escoand deleted the escoand:patch-1 branch Jun 28, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.