Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disconnect bug in Tibber library #22629

Merged
merged 1 commit into from Apr 1, 2019

Conversation

Projects
None yet
3 participants
@Danielhiversen
Copy link
Member

commented Apr 1, 2019

Description:

Fix disconnect bug in Tibber library
https://github.com/Danielhiversen/pyTibber/commits/master

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@ghost ghost assigned Danielhiversen Apr 1, 2019

@ghost ghost added the in progress label Apr 1, 2019

@Danielhiversen Danielhiversen changed the title Handle disonnect bug in Tibber library Fix disconnect bug in Tibber library Apr 1, 2019

@balloob

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Want this in 91?

@balloob

balloob approved these changes Apr 1, 2019

@balloob balloob merged commit 2e02efe into dev Apr 1, 2019

12 checks passed

Hound No violations found. Woof!
build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA

@ghost ghost removed the in progress label Apr 1, 2019

@delete-merged-branch delete-merged-branch bot deleted the tibber_0101 branch Apr 1, 2019

@Danielhiversen Danielhiversen added this to the 0.91.0 milestone Apr 1, 2019

balloob added a commit that referenced this pull request Apr 2, 2019

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.