Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device class lookup for ZHA binary sensors #22724

Merged
merged 1 commit into from Apr 4, 2019

Conversation

Projects
None yet
5 participants
@dmulcahey
Copy link
Contributor

commented Apr 4, 2019

Description:

Fix the device class lookup for ZHA binary sensors. We recently changed the channel names to leverage zigpy to create alignment. This area was an oversight.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@dmulcahey dmulcahey added this to the 0.91.1 milestone Apr 4, 2019

@dmulcahey dmulcahey requested a review from Adminiuga Apr 4, 2019

@ghost ghost assigned dmulcahey Apr 4, 2019

@ghost ghost added the in progress label Apr 4, 2019

@github-actions

This comment has been minimized.

Copy link

commented Apr 4, 2019

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

@cgarwood cgarwood merged commit e29eb4f into home-assistant:dev Apr 4, 2019

10 checks passed

ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA

@ghost ghost removed the in progress label Apr 4, 2019

balloob added a commit that referenced this pull request Apr 5, 2019

@balloob balloob referenced this pull request Apr 5, 2019

Merged

0.91.1 #22755

unibeck pushed a commit to unibeck/home-assistant that referenced this pull request Apr 7, 2019

@dmulcahey dmulcahey deleted the dmulcahey:dm/zha-fix-device-class branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.