Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ingress routing with / #22728

Merged
merged 1 commit into from Apr 4, 2019

Conversation

Projects
None yet
3 participants
@pvizeli
Copy link
Member

commented Apr 4, 2019

Description:

Fix a bug with routing simple "/"

@pvizeli pvizeli added this to the 0.91.1 milestone Apr 4, 2019

@ghost ghost assigned pvizeli Apr 4, 2019

@ghost ghost added the in progress label Apr 4, 2019

@github-actions

This comment has been minimized.

Copy link

commented Apr 4, 2019

Hey there @home-assistant/hass-io, mind taking a look at this pull request as its been labeled with a integration (hassio) you are listed as a codeowner for? Thanks!

@codecov

This comment has been minimized.

Copy link

commented Apr 4, 2019

Codecov Report

Merging #22728 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #22728   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files         449      449           
  Lines       36568    36568           
=======================================
  Hits        34317    34317           
  Misses       2251     2251
Impacted Files Coverage Δ
homeassistant/components/hassio/ingress.py 71.05% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e29eb4f...50a2734. Read the comment docs.

@pvizeli pvizeli merged commit 9bb88a6 into dev Apr 4, 2019

20 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 93.84%)
Details
codecov/project 93.84% (target 90%)
Details
codeowners-mention codeowners-mention
Details
codeowners-mention codeowners-mention
Details
codeowners-mention codeowners-mention
Details
codeowners-mention codeowners-mention
Details
codeowners-mention codeowners-mention
Details
codeowners-mention codeowners-mention
Details
codeowners-mention codeowners-mention
Details

@ghost ghost removed the in progress label Apr 4, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-routing-ingress branch Apr 4, 2019

balloob added a commit that referenced this pull request Apr 5, 2019

@balloob balloob referenced this pull request Apr 5, 2019

Merged

0.91.1 #22755

unibeck pushed a commit to unibeck/home-assistant that referenced this pull request Apr 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.