Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect "Unavailable" Ambient sensors #22734

Merged
merged 2 commits into from Apr 4, 2019

Conversation

Projects
None yet
3 participants
@bachya
Copy link
Contributor

commented Apr 4, 2019

Description:

In situations where an Ambient sensor would have a value of 0, the component would interpret that as a falsey value, thus rendering Unavailable. This PR fixes that.

Related issue (if applicable): fixes #22733

Pull request in home-assistant.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

ambient_station:
  api_key: !secret ambient_api_key
  app_key: !secret ambient_app_key

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
@github-actions

This comment has been minimized.

Copy link

commented Apr 4, 2019

Hey there @bachya, mind taking a look at this pull request as its been labeled with a integration (ambient_station) you are listed as a codeowner for? Thanks!

@bachya bachya added this to the 0.91.1 milestone Apr 4, 2019

@bachya bachya merged commit 96adbfd into home-assistant:dev Apr 4, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 07d739c...e8b459c
Details
codecov/project 93.84% (target 90%)
Details

@ghost ghost removed the in progress label Apr 4, 2019

@bachya bachya deleted the bachya:ambient-unavailable branch Apr 4, 2019

balloob added a commit that referenced this pull request Apr 5, 2019

Fix incorrect "Unavailable" Ambient sensors (#22734)
* Fix incorrect "Unavailable" Ambient sensors

* Removed unnecessary cast

@balloob balloob referenced this pull request Apr 5, 2019

Merged

0.91.1 #22755

unibeck pushed a commit to unibeck/home-assistant that referenced this pull request Apr 7, 2019

Fix incorrect "Unavailable" Ambient sensors (home-assistant#22734)
* Fix incorrect "Unavailable" Ambient sensors

* Removed unnecessary cast
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.