Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aioambient to 0.2.0 #22736

Merged
merged 1 commit into from Apr 4, 2019

Conversation

Projects
None yet
3 participants
@bachya
Copy link
Contributor

commented Apr 4, 2019

Description:

Changelog: https://github.com/bachya/aioambient/releases/tag/0.2.0

Related issue (if applicable): fixes #22636

Pull request in home-assistant.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

ambient_station:
  api_key: !secret ambient_api_key
  app_key: !secret ambient_app_key

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
@github-actions

This comment has been minimized.

Copy link

commented Apr 4, 2019

Hey there @bachya, mind taking a look at this pull request as its been labeled with a integration (ambient_station) you are listed as a codeowner for? Thanks!

@bachya bachya added this to the 0.91.1 milestone Apr 4, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 4, 2019

Codecov Report

Merging #22736 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #22736      +/-   ##
==========================================
- Coverage   93.84%   93.84%   -0.01%     
==========================================
  Files         449      449              
  Lines       36568    36568              
==========================================
- Hits        34317    34316       -1     
- Misses       2251     2252       +1
Impacted Files Coverage Δ
homeassistant/components/websocket_api/http.py 88.52% <0%> (-0.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07d739c...b5d5039. Read the comment docs.

@bachya bachya merged commit 0438dff into home-assistant:dev Apr 4, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 07d739c...b5d5039
Details
codecov/project 93.84% (target 90%)
Details

@ghost ghost removed the in progress label Apr 4, 2019

@bachya bachya deleted the bachya:ambient-bump branch Apr 4, 2019

balloob added a commit that referenced this pull request Apr 5, 2019

@balloob balloob referenced this pull request Apr 5, 2019

Merged

0.91.1 #22755

unibeck pushed a commit to unibeck/home-assistant that referenced this pull request Apr 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.