Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for optional values in the update_location webhook call #22817

Merged
merged 2 commits into from Apr 7, 2019

Conversation

Projects
None yet
5 participants
@robbiet480
Copy link
Member

commented Apr 7, 2019

Optional values weren't correctly being added to the device_tracker.see payload causing schema errors, originally detected from location_name.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
@balloob

balloob approved these changes Apr 7, 2019

@awarecan awarecan merged commit 6492809 into dev Apr 7, 2019

14 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 8c17b2f...540b784
Details
codecov/project 93.82% (target 90%)
Details
codeowners-mention codeowners-mention
Details

@ghost ghost removed the in progress label Apr 7, 2019

@delete-merged-branch delete-merged-branch bot deleted the mobile_app-location-name-fix branch Apr 7, 2019

unibeck pushed a commit to unibeck/home-assistant that referenced this pull request Apr 7, 2019

Fix for optional values in the update_location webhook call (home-ass…
…istant#22817)

* Fix for optional values in the update_location webhook call

* Square brackets instead of .get

pvizeli added a commit that referenced this pull request Apr 8, 2019

Fix for optional values in the update_location webhook call (#22817)
* Fix for optional values in the update_location webhook call

* Square brackets instead of .get

@pvizeli pvizeli referenced this pull request Apr 8, 2019

Merged

0.91.2 #22883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.