Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative imports in yeelight #22839

Merged
merged 1 commit into from Apr 7, 2019

Conversation

@zewelor
Copy link
Contributor

commented Apr 7, 2019

Description:

Yeelight wasn't component when doing auto import change #22235

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
@github-actions

This comment has been minimized.

Copy link

commented Apr 7, 2019

Hey there @rytilahti, mind taking a look at this pull request as its been labeled with a integration (yeelight) you are listed as a codeowner for? Thanks!

@syssi syssi added this to the 0.91.2 milestone Apr 7, 2019

@syssi

syssi approved these changes Apr 7, 2019

@syssi

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

Can be merged if build pass.

@syssi syssi closed this Apr 7, 2019

@syssi syssi reopened this Apr 7, 2019

@ghost ghost removed the in progress label Apr 7, 2019

@syssi syssi merged commit bb5c18f into home-assistant:dev Apr 7, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 6492809...d47ae4b
Details
codecov/project 93.83% (target 90%)
Details

unibeck pushed a commit to unibeck/home-assistant that referenced this pull request Apr 7, 2019

pvizeli added a commit that referenced this pull request Apr 8, 2019

@pvizeli pvizeli referenced this pull request Apr 8, 2019

Merged

0.91.2 #22883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.