Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yeelight possible array change during iteration #22849

Conversation

@zewelor
Copy link
Contributor

commented Apr 7, 2019

Description:

Fix for possible array change during iteration.

Related issue (if applicable): fixes #22841

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
@github-actions

This comment has been minimized.

Copy link

commented Apr 7, 2019

Hey there @rytilahti, mind taking a look at this pull request as its been labeled with a integration (yeelight) you are listed as a codeowner for? Thanks!

@syssi

syssi approved these changes Apr 7, 2019

Copy link
Member

left a comment

LGTM!

@syssi syssi added this to the 0.91.2 milestone Apr 7, 2019

@bachya bachya merged commit e407226 into home-assistant:dev Apr 7, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 02b7fd9...adc5eed
Details
codecov/project 93.83% (target 90%)
Details

@ghost ghost removed the in progress label Apr 7, 2019

@zewelor zewelor deleted the zewelor:fix_yeelight_update_with_possible_dict_change branch Apr 7, 2019

pvizeli added a commit that referenced this pull request Apr 8, 2019

@pvizeli pvizeli referenced this pull request Apr 8, 2019

Merged

0.91.2 #22883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.