Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream support for Doorbird component #22876

Merged
merged 8 commits into from Apr 8, 2019

Conversation

Projects
None yet
3 participants
@oblogic7
Copy link
Contributor

commented Apr 8, 2019

Description:

Add support for stream component to cameras created by Doorbird component

Related issue (if applicable): fixes #22742

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • [The manifest file][manifest-docs] has all fields filled out correctly ([example][ex-manifest]).
  • New dependencies have been added to requirements in the manifest ([example][ex-requir]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

image

oblogic7 added some commits Apr 8, 2019

@hunterjm
Copy link
Contributor

left a comment

Looks good. A few things to pass lint.

@@ -31,8 +31,10 @@
async_add_entities([
DoorBirdCamera(
device.live_image_url,
device.rtsp_live_video_url,

This comment has been minimized.

Copy link
@hunterjm

hunterjm Apr 8, 2019

Contributor

Looks like this is in the wrong place. Will set name to stream.

_CAMERA_LIVE.format(doorstation.name),
_LIVE_INTERVAL),
_LIVE_INTERVAL,
stream_url=device.rtsp_live_video_url),

This comment has been minimized.

Copy link
@hunterjm

hunterjm Apr 8, 2019

Contributor

Once above is fixed, can remove stream_url=

@codecov

This comment has been minimized.

Copy link

commented Apr 8, 2019

Codecov Report

Merging #22876 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #22876   +/-   ##
=======================================
  Coverage   93.83%   93.83%           
=======================================
  Files         448      448           
  Lines       36528    36528           
=======================================
  Hits        34275    34275           
  Misses       2253     2253
Impacted Files Coverage Δ
...ssistant/components/islamic_prayer_times/sensor.py 94.73% <0%> (-1.06%) ⬇️
homeassistant/components/uk_transport/sensor.py 94.16% <0%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a40a0c4...cdaf8b9. Read the comment docs.

@hunterjm hunterjm merged commit 36c135c into home-assistant:dev Apr 8, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing a40a0c4...cdaf8b9
Details
codecov/project 93.83% (target 90%)
Details

@ghost ghost removed the in progress label Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.