Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sonos handling of unsupported favorites #22906

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
3 participants
@amelchio
Copy link
Contributor

amelchio commented Apr 8, 2019

Description:

Any invalid XML should be handled by pysonos by now and if it isn't, I want to see the backtrace so I can fix it.

Related issue (if applicable): fixes #22714

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
@andrewsayre
Copy link
Contributor

andrewsayre left a comment

Looks good!

@andrewsayre andrewsayre merged commit d577955 into home-assistant:dev Apr 9, 2019

12 checks passed

ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 55c8417...38fe9a2
Details
codecov/project 93.83% (target 90%)
Details

@wafflebot wafflebot bot removed the in progress label Apr 9, 2019

@amelchio amelchio referenced this pull request Apr 9, 2019

Merged

Hide unsupported Sonos favorites #22940

8 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.