Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloudhook and remote UI vals to get_config #22921

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
5 participants
@robbiet480
Copy link
Member

commented Apr 9, 2019

Description:

Adding these keys so that if cloud is added later apps don't have to ask users to type them manually.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

"plz review my smol pr"

@Swamp-Ig Swamp-Ig requested review from Swamp-Ig and removed request for Swamp-Ig Apr 9, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 9, 2019

Codecov Report

Merging #22921 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #22921      +/-   ##
==========================================
+ Coverage   93.83%   93.83%   +<.01%     
==========================================
  Files         448      448              
  Lines       36583    36574       -9     
==========================================
- Hits        34329    34321       -8     
+ Misses       2254     2253       -1
Impacted Files Coverage Δ
homeassistant/components/heos/config_flow.py 100% <0%> (ø) ⬆️
homeassistant/components/stream/worker.py 93.61% <0%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ee23bd...a8938ff. Read the comment docs.

@cgarwood cgarwood merged commit 75bed93 into dev Apr 9, 2019

25 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 6ee23bd...a8938ff
Details
codecov/project 93.83% (target 90%)
Details
codeowners-mention codeowners-mention
Details
codeowners-mention codeowners-mention
Details
codeowners-mention codeowners-mention
Details
codeowners-mention codeowners-mention
Details
codeowners-mention codeowners-mention
Details
codeowners-mention codeowners-mention
Details
codeowners-mention codeowners-mention
Details
codeowners-mention codeowners-mention
Details
codeowners-mention codeowners-mention
Details
codeowners-mention codeowners-mention
Details
codeowners-mention codeowners-mention
Details
codeowners-mention codeowners-mention
Details

@ghost ghost removed the in progress label Apr 9, 2019

@delete-merged-branch delete-merged-branch bot deleted the mobile_app-add-config-keys branch Apr 9, 2019

pvizeli added a commit that referenced this pull request Apr 10, 2019

@pvizeli pvizeli referenced this pull request Apr 10, 2019

Merged

0.91.3 #22969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.