Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide unsupported Sonos favorites #22940

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
3 participants
@amelchio
Copy link
Contributor

amelchio commented Apr 9, 2019

Description:

Follow-up to #22906. The unsupported favorites are now hidden. This seems better than having unusable entries showing.

Related issue (if applicable): fixes #22714

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
@ludeeus

ludeeus approved these changes Apr 9, 2019

Copy link
Contributor

ludeeus left a comment

Can be merged when tests pass

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #22940 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #22940      +/-   ##
==========================================
+ Coverage   93.85%   93.85%   +<.01%     
==========================================
  Files         449      449              
  Lines       36752    36683      -69     
==========================================
- Hits        34492    34429      -63     
+ Misses       2260     2254       -6
Impacted Files Coverage Δ
homeassistant/bootstrap.py 58.08% <0%> (-0.71%) ⬇️
homeassistant/loader.py 97.12% <0%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4803f31...b46416b. Read the comment docs.

@amelchio amelchio merged commit 6244a39 into home-assistant:dev Apr 9, 2019

12 checks passed

ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 4803f31...b46416b
Details
codecov/project 93.85% (target 90%)
Details

@wafflebot wafflebot bot removed the in progress label Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.