Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream support for Netatmo cameras #22952

Merged
merged 4 commits into from Apr 10, 2019

Conversation

Projects
None yet
3 participants
@cgtobi
Copy link
Collaborator

commented Apr 9, 2019

Breaking Change:

Should not break anything.

Description:

This will add stream support for Netatmo cameras.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9182

Example entry for configuration.yaml (if applicable):

camera:
  - platform: netatmo
    quality: high

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned cgtobi Apr 9, 2019

@ghost ghost added the in progress label Apr 9, 2019

@cgtobi cgtobi referenced this pull request Apr 9, 2019

Merged

Introduce quality parameter for live streaming #9182

2 of 2 tasks complete

@cgtobi cgtobi marked this pull request as ready for review Apr 9, 2019

cgtobi added some commits Apr 9, 2019

@balloob balloob merged commit c2cfc4a into home-assistant:dev Apr 10, 2019

10 checks passed

ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA

@ghost ghost removed the in progress label Apr 10, 2019

@cgtobi cgtobi deleted the cgtobi:netatmo_camera_stream branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.