Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Netgear LTE sms_total sensor #22954

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
3 participants
@amelchio
Copy link
Contributor

amelchio commented Apr 9, 2019

Description:

Add a sensor with the total number of SMS messages in the modem inbox. This is in addition to the current "sms" sensor that has the number of unread messages.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9076

Example entry for configuration.yaml (if applicable):

netgear_lte:
  - host: !secret lb2120_hostname
    password: !secret lb2120_password
    sensor:
      monitored_conditions:
        - sms_total

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #22954 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #22954      +/-   ##
==========================================
- Coverage   93.84%   93.84%   -0.01%     
==========================================
  Files         449      449              
  Lines       36761    36752       -9     
==========================================
- Hits        34500    34491       -9     
  Misses       2261     2261
Impacted Files Coverage Δ
homeassistant/components/homekit/util.py 99.05% <0%> (ø) ⬆️
homeassistant/components/homekit/accessories.py 100% <0%> (ø) ⬆️
homeassistant/bootstrap.py 58.78% <0%> (ø) ⬆️
homeassistant/components/homekit/const.py 100% <0%> (ø) ⬆️
homeassistant/components/mqtt/const.py 100% <0%> (ø) ⬆️
homeassistant/config.py 94.67% <0%> (ø) ⬆️
homeassistant/loader.py 94.28% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e48ef7f...3820e24. Read the comment docs.

@cgtobi

cgtobi approved these changes Apr 10, 2019

Copy link
Collaborator

cgtobi left a comment

LGTM

@amelchio amelchio merged commit a833736 into home-assistant:dev Apr 10, 2019

12 checks passed

ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing e48ef7f...3820e24
Details
codecov/project 93.84% (target 90%)
Details

@wafflebot wafflebot bot removed the in progress label Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.