Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Pollen.com sensor into IQVIA component #22986

Merged
merged 9 commits into from Apr 25, 2019

Conversation

@bachya
Copy link
Contributor

commented Apr 11, 2019

Breaking Change:

The pollen sensor platform is now the iqvia component; the configuration.yaml schema has changed accordingly.

Description:

In expanding the functionality of the pollen sensor, I realized that the parent company (IQVIA) hosts a variety of sites (https://pollen.com, https://flustar.com, etc.) from which valid data can come. To accommodate this, I want to generalize the pollen sensor into the iqvia component.

The PR does two things:

  1. Moves from pypollencom to pyiqvia.
  2. Performs all of the necessary work to move the integration to the iqvia component.

This PR is a tad bigger than I would like, but it is in place to avoid multiple breaking changes. It does not implement a config entry; that will come in a separate PR.

Related issue (if applicable): N/A

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9194

Example entry for configuration.yaml (if applicable):

iqvia:
  zip_code: "12345"

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
@codecov

This comment has been minimized.

Copy link

commented Apr 11, 2019

Codecov Report

Merging #22986 into dev will decrease coverage by 0.57%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #22986      +/-   ##
==========================================
- Coverage   94.13%   93.56%   -0.58%     
==========================================
  Files         448      451       +3     
  Lines       36720    36946     +226     
==========================================
+ Hits        34567    34568       +1     
- Misses       2153     2378     +225
Impacted Files Coverage Δ
homeassistant/components/iqvia/const.py 0% <0%> (ø)
homeassistant/components/iqvia/__init__.py 0% <0%> (ø)
homeassistant/components/iqvia/sensor.py 0% <0%> (ø)
homeassistant/components/uk_transport/sensor.py 94.16% <0%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2cfc4a...af05f80. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Apr 11, 2019

Codecov Report

Merging #22986 into dev will decrease coverage by 0.57%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #22986      +/-   ##
==========================================
- Coverage   94.13%   93.56%   -0.58%     
==========================================
  Files         448      451       +3     
  Lines       36720    36946     +226     
==========================================
+ Hits        34567    34568       +1     
- Misses       2153     2378     +225
Impacted Files Coverage Δ
homeassistant/components/iqvia/const.py 0% <0%> (ø)
homeassistant/components/iqvia/__init__.py 0% <0%> (ø)
homeassistant/components/iqvia/sensor.py 0% <0%> (ø)
homeassistant/components/uk_transport/sensor.py 94.16% <0%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2cfc4a...af05f80. Read the comment docs.

@bachya bachya referenced this pull request Apr 12, 2019

Closed

Add current and historical disease data to IQVIA #23050

3 of 4 tasks complete

@bachya bachya force-pushed the bachya:iqvia branch from 5871ff4 to 6ed7f1d Apr 12, 2019

@bachya bachya referenced this pull request Apr 12, 2019

Merged

Add current disease data to IQVIA #23052

4 of 4 tasks complete

@bachya bachya force-pushed the bachya:iqvia branch 2 times, most recently from 3932b97 to 057f851 Apr 15, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 19, 2019

Codecov Report

Merging #22986 into dev will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #22986     +/-   ##
=========================================
- Coverage   94.29%   94.09%   -0.2%     
=========================================
  Files         458      452      -6     
  Lines       37160    36797    -363     
=========================================
- Hits        35040    34625    -415     
- Misses       2120     2172     +52
Impacted Files Coverage Δ
homeassistant/components/mqtt/fan.py 74.19% <0%> (-23.78%) ⬇️
homeassistant/bootstrap.py 59.25% <0%> (-15.15%) ⬇️
homeassistant/components/hassio/ingress.py 67.76% <0%> (-10.29%) ⬇️
homeassistant/components/axis/device.py 93.18% <0%> (-6.82%) ⬇️
homeassistant/components/hue/bridge.py 73.07% <0%> (-1%) ⬇️
homeassistant/loader.py 93.15% <0%> (-0.72%) ⬇️
homeassistant/components/axis/camera.py 90.24% <0%> (-0.67%) ⬇️
homeassistant/components/hassio/auth.py 90.47% <0%> (-0.44%) ⬇️
homeassistant/helpers/service.py 91.58% <0%> (-0.4%) ⬇️
homeassistant/components/hassio/handler.py 95.52% <0%> (-0.13%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c899e2a...057f851. Read the comment docs.

@bachya bachya referenced this pull request Apr 19, 2019

Merged

Remove historical allergen and asthma sensors from IQVIA #23258

3 of 4 tasks complete

bachya added some commits Apr 6, 2019

@bachya bachya force-pushed the bachya:iqvia branch from 057f851 to d937760 Apr 24, 2019

Show resolved Hide resolved homeassistant/components/iqvia/__init__.py Outdated

bachya added some commits Apr 24, 2019

@bachya bachya merged commit 0d796a0 into home-assistant:dev Apr 25, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 96735e4...4467c30
Details
codecov/project 94.31% (target 90%)
Details

@bachya bachya deleted the bachya:iqvia branch Apr 25, 2019

@bachya bachya referenced this pull request Apr 25, 2019

Merged

Additional cleanup of IQVIA integration #23403

3 of 3 tasks complete

@balloob balloob referenced this pull request May 14, 2019

Merged

0.93.0 #23864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.