Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded python-velbus package, this fixes a lot of problems with the… #23100

Merged
merged 2 commits into from Apr 15, 2019

Conversation

Projects
None yet
3 participants
@Cereal2nd
Copy link
Contributor

Cereal2nd commented Apr 14, 2019

… velbus component

Description:

This just upgrades to the latest velbus package to fix a lot of bugs

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
@balloob

This comment has been minimized.

Copy link
Member

balloob commented Apr 14, 2019

Update requirements in manifest.json and then, per the instruction in the PR that you checked that you did, run script/gen_requirements_all.py

@Cereal2nd

This comment has been minimized.

Copy link
Contributor Author

Cereal2nd commented Apr 14, 2019

Fixed, i did run the requirements script but weeks ago, before th requirements thing changed, that's why i missed this.

@balloob balloob merged commit 96f689a into home-assistant:dev Apr 15, 2019

12 checks passed

ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 3368e30...c84f8c7
Details
codecov/project 93.95% (target 90%)
Details

@wafflebot wafflebot bot removed the in progress label Apr 15, 2019

@balloob

This comment has been minimized.

Copy link
Member

balloob commented Apr 15, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.