Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT Vacuum State Device #23171

Merged
merged 13 commits into from Apr 22, 2019

Conversation

@pszafer
Copy link
Contributor

commented Apr 17, 2019

Description:

Soft transition from VacuumDevice to StateVacuumDevice: Add support for an MQTT Vacuum to represented by either a VacuumDevice or a StateVacuumDevice. Over time, we should deprecate and finally drop support for VacuumDevice.

Background: home-assistant/architecture#29

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

I will write documentation when you accept PR.

@github-actions

This comment has been minimized.

Copy link

commented Apr 17, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (mqtt) you are listed as a codeowner for? Thanks!

@codecov

This comment has been minimized.

Copy link

commented Apr 18, 2019

Codecov Report

Merging #23171 into dev will decrease coverage by 0.05%.
The diff coverage is 98.63%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev   #23171      +/-   ##
=========================================
- Coverage   94.3%   94.24%   -0.06%     
=========================================
  Files        457      455       -2     
  Lines      37106    37091      -15     
=========================================
- Hits       34991    34958      -33     
- Misses      2115     2133      +18
Impacted Files Coverage Δ
...eassistant/components/mqtt/vacuum/schema_legacy.py 99.12% <100%> (ø)
homeassistant/components/mqtt/vacuum/__init__.py 100% <100%> (ø)
...meassistant/components/mqtt/vacuum/schema_state.py 98.1% <98.1%> (ø)
homeassistant/components/mqtt/fan.py 74.19% <0%> (-23.78%) ⬇️
homeassistant/components/hue/bridge.py 73.07% <0%> (-1%) ⬇️
homeassistant/helpers/service.py 91.58% <0%> (-0.4%) ⬇️
homeassistant/components/cloud/http_api.py 99.01% <0%> (ø) ⬆️
homeassistant/components/google_assistant/const.py 100% <0%> (ø) ⬆️
homeassistant/components/hue/binary_sensor.py
homeassistant/components/google_assistant/error.py
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a7bd19...5c95dc0. Read the comment docs.

@pszafer pszafer marked this pull request as ready for review Apr 18, 2019

@pszafer pszafer requested a review from home-assistant/core as a code owner Apr 18, 2019

@pszafer pszafer force-pushed the pszafer:vacuum_mqtt_state branch from 3f6369e to 5c95dc0 Apr 19, 2019

@emontnemery
Copy link
Contributor

left a comment

Looks good!



@pytest.fixture
def mock_publish(hass):

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Apr 22, 2019

Member

Why can't we use the existing mqtt_mock fixture that all mqtt tests have available?

This comment has been minimized.

Copy link
@pszafer

pszafer Apr 22, 2019

Author Contributor

It was copy paste from old vacuum tests. Deleted it.

pszafer added some commits Apr 17, 2019

@pszafer pszafer force-pushed the pszafer:vacuum_mqtt_state branch from 6db91cd to 3a2b9d4 Apr 22, 2019

@emontnemery emontnemery merged commit 9007e17 into home-assistant:dev Apr 22, 2019

12 of 13 checks passed

codecov/patch 94.06% of diff hit (target 94.29%)
Details
build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/project 94.31% (target 90%)
Details
@pszafer pszafer referenced this pull request Apr 23, 2019
2 of 2 tasks complete
@balloob balloob referenced this pull request May 14, 2019
@pilot1981

This comment has been minimized.

Copy link

commented May 17, 2019

Hi,
where I can find supported vacuum? it can support also THEHOOKUP code for Roomba 5xx?

https://github.com/thehookup/MQTT-Roomba-ESP01

@pszafer

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2019

https://github.com/Hypfer/Valetudo/ is using state vacuum.
Roomba is still legacy vacuum AFAIK. You can ask author of MQTT-Roomba-ESP01 to switch to newer version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.