Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @Jc2k to codeowners for homekit_controller #23173

Merged
merged 1 commit into from Apr 18, 2019

Conversation

Projects
None yet
5 participants
@Jc2k
Copy link
Contributor

commented Apr 17, 2019

Add myself to codeowners for homekit_controller as requested by @balloob in #23046.

@codecov

This comment has been minimized.

Copy link

commented Apr 18, 2019

Codecov Report

Merging #23173 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #23173      +/-   ##
==========================================
+ Coverage   94.19%    94.2%   +<.01%     
==========================================
  Files         453      453              
  Lines       36915    36915              
==========================================
+ Hits        34773    34776       +3     
+ Misses       2142     2139       -3
Impacted Files Coverage Δ
...ssistant/components/islamic_prayer_times/sensor.py 97.87% <0%> (+3.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0afa016...549512e. Read the comment docs.

@awarecan awarecan merged commit 6bb4199 into home-assistant:dev Apr 18, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 0afa016...549512e
Details
codecov/project 94.2% (target 90%)
Details

@awarecan awarecan removed the in progress label Apr 18, 2019

@Jc2k Jc2k deleted the Jc2k:homekit_controller_codeowners branch Apr 18, 2019

@balloob balloob referenced this pull request May 14, 2019

Merged

0.93.0 #23864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.