Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improve IndieAuth redirect_uri lookup failure logs #23183

Merged
merged 1 commit into from Apr 18, 2019

Conversation

Projects
None yet
4 participants
@robbiet480
Copy link
Member

commented Apr 18, 2019

Continuing work from #21780, this PR adds some more specific logging for common errors that I've seen reported from iOS users. The excepts are ordered in the same way as the aiohttp Hierarchy of exceptions.

@robbiet480 robbiet480 requested a review from home-assistant/core as a code owner Apr 18, 2019

@github-actions

This comment has been minimized.

Copy link

commented Apr 18, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (auth) you are listed as a codeowner for? Thanks!

@robbiet480 robbiet480 force-pushed the more-indieauth-logging branch from 1116936 to 59f428c Apr 18, 2019

@@ -81,8 +80,22 @@ def handle_starttag(self, tag, attrs):
if chunks == 10:
break

except (asyncio.TimeoutError, ClientError) as ex:
_LOGGER.error("Error while looking up redirect_uri %s: %s", url, ex)

This comment has been minimized.

Copy link
@balloob

balloob Apr 18, 2019

Member

Is the error message ex not descriptive enough?

This comment has been minimized.

Copy link
@robbiet480

robbiet480 Apr 18, 2019

Author Member

There's no string version of ClientError sadly, so nothing is output for that bit.

@codecov

This comment has been minimized.

Copy link

commented Apr 18, 2019

Codecov Report

Merging #23183 into dev will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #23183      +/-   ##
==========================================
- Coverage   94.21%   94.17%   -0.04%     
==========================================
  Files         457      457              
  Lines       37085    37096      +11     
==========================================
- Hits        34938    34937       -1     
- Misses       2147     2159      +12
Impacted Files Coverage Δ
homeassistant/components/auth/indieauth.py 77.08% <0%> (-11.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a2a130...59f428c. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Apr 18, 2019

Codecov Report

Merging #23183 into dev will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #23183      +/-   ##
==========================================
- Coverage   94.21%   94.17%   -0.04%     
==========================================
  Files         457      457              
  Lines       37085    37096      +11     
==========================================
- Hits        34938    34937       -1     
- Misses       2147     2159      +12
Impacted Files Coverage Δ
homeassistant/components/auth/indieauth.py 77.08% <0%> (-11.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a2a130...59f428c. Read the comment docs.

@balloob balloob merged commit 5e1338a into dev Apr 18, 2019

13 of 14 checks passed

codecov/patch 0% of diff hit (target 94.21%)
Details
build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/project 94.17% (target 90%)
Details
codeowners-mention codeowners-mention
Details

@delete-merged-branch delete-merged-branch bot deleted the more-indieauth-logging branch Apr 18, 2019

@balloob balloob removed the in progress label Apr 18, 2019

@robbiet480 robbiet480 added this to the 0.92.2 milestone Apr 28, 2019

balloob added a commit that referenced this pull request May 2, 2019

@balloob balloob referenced this pull request May 2, 2019

Merged

0.92.2 #23620

Kiku-git added a commit to Kiku-git/home-assistant that referenced this pull request May 16, 2019

fix (#2)
* Fix netatmo_public sensor to use netatmo authentication (home-assistant#23455)

* Bump amcrest to 1.4.0 and use new storage_all method (home-assistant#23446)

Improve sdcard sensor so it only sends one command to camera per update as opposed to the four it used to send to reduce network traffic and make data consistent. Also better handle returned values of 'unknown'.

* Added option to use self-signed certificates (home-assistant#23139)

* Added option to use self-signed certificates

I defined a new option for configuration.yaml, 'verify_ssl', which is set to 'True' by default for obvious security reasons. However, in order to work with self-signed certificates, it is now possible to disable the certificate validation.(eg, I use a nextcloud instance with self-signed certificates)
Credit for code in line 57 goes to user 'gen2' on the homeassistant community, who suggested this solution. 
https://community.home-assistant.io/t/caldav-configuration/38198/25
I only took it a step further and made it a config option.

* Update calendar.py

* Added the import of CONF_VERIFY_SSL

I hope this passes the test now...

* Update homeassistant/components/caldav/calendar.py

Cool! Didn't know about that possibility, my coding experience is literally two weeks. Thanks for sharing!

Co-Authored-By: anrudolph <49680492+anrudolph@users.noreply.github.com>

* Removed some lines of code

I think, in order for the last commit to work, these lines have to be removed. Correct?

* Trying to get this passing the checks

Trying around to get the simplified code to work

* No longer promote imports inside methods (home-assistant#23471)

* Bump pychromecast (home-assistant#23463)

* Improve handling of unavailable Sonos speakers (home-assistant#23472)

* Use remote image for HEOS (home-assistant#23420)

* Fix Hue sensors returning None value (home-assistant#23478)

* Add a warning that honeywell/EU is to be deprecated (home-assistant#23469)

* Add a warning that honeywell/EU is to be deprecated

* improve warning

* Updated frontend to 20190427.0

* Updated frontend to 20190427.0

* Only include agent user ID in SYNC responses (home-assistant#23497)

* Skip flaky stream tests (home-assistant#23493)

* Skip flaky test_hls tests

* Skip flaky test_recorder tests

* Display person component as occupancy sensor HomeKit (home-assistant#23451)

* Fixes local_file camera service (home-assistant#23479)

* Fixes service

Fixes service so only the target camera is updated

* Update test_camera.py

* fix lint

* Update aiolifx_effects to 0.2.2 (home-assistant#23473)

* Catch RequestException in influxdb writer (home-assistant#23508)

* Fixed bug with max_result (home-assistant#23507)

The config option 'max_result' was assigned to not existing 'max_result' variable, it should be assigned to 'maxResult'.
The current version causes an error when max_result option is used.

* Fix cleanup of dynamic group (home-assistant#23475)

* Return state when changing optimistic covers (home-assistant#23498)

* Update Philips js to v0.0.8 (home-assistant#23462)

* Don't send volume on volume set

This needs updated lib

* Bump version and avoid getting channels explicitly

* Add myself as codeowner

* Use version 0.0.8 instead which doesn't reuse session

Some TV's doesn't play nice with HTTP/1.1 connection
re-use.

* Add new requirement to requirements_all.txt

* Fixed AlexaPowerController to report power state for thermostats (home-assistant#23468)

Fixed AlexaPowerController to report power state for thermostats, to look if state is OFF return OFF, otherwise report ON as thermostats have multiple values for ON

* Continuous discovery of Sonos speakers (home-assistant#23484)

* Ignore stale directories (home-assistant#23464)

* Ignore stale directories

* Remove redundant tests

* Revert "Remove redundant tests"

* Print warning when skipping directories

* Suggest to remove stale directory

* Do not log tracebacks for influxdb write errors (home-assistant#23522)

* Do not log influxdb write exceptions

* Log exception name

* Allow device_class for template covers

* home-assistant#23486. Allows device_class to be set for template covers

* limit concurrent updates to avoid network flood (home-assistant#23534)

* Add current disease data to IQVIA (home-assistant#23052)

* Add current and historical disease data to IQVIA

* Added fetcher

* Added disease sensor mapping

* Changed incorrect key

* Removed other extraneous const usage

* Allow direct binding via ZHA for the ZLL profile (home-assistant#23536)

* allow binding for zll profile
* update check - review comment

* Improve logging of exceptions in async_create_task (home-assistant#22689)

* Improve logging of exceptions in async_create_task

* Move wrapping+logging to util.logging

* Minor refactor, fix typing

* Add test

* Remove useless @wraps, fix confusing parameter name

* Review comment

* Install requirements when checking config (home-assistant#23500)

* Install requirements when checking config

* PyLint

* Fix media_player alexa power control bug (home-assistant#23537)

* Always print invalid configuration data (home-assistant#21972)

* Always print invalide configuration data

* Print offending data as yaml

* Revert "Print offending data as yaml"

This reverts commit 01721a2.

* Do not print sensitive data

* Print MQTT topic

* Add line break

* Review comments

* review comments

* Don't use zigpy profiles for ZHA entities (home-assistant#22844)

* don't use zigpy profiles
* use sets as they're the correct structure to use

* Add HomeKit low battery threshold config (home-assistant#23363)

* Add sensor support for dyson 2018 models (home-assistant#22578)

fix check for already created entities

remove hepa and carbon filter

add AQI attribute

initial commit

fix check for already created entities

remove hepa and carbon filter

add AQI attribute

add air quality component tests

fix method call tests

fix line lengths

fix pylint issues

fix docstrings

revert fan related changes

remove whitespace change

fix fan update state test

add for loop for platform initialization

add requested changes to aiq platform

change string concatenation to new style string formatting

update air quality tests

update air quality tests

refactor sensor component changes

fix pylint issues

fix debug string in the air quality component

replace failing tests for older devices

fix line length fan tests

remove dependencies const and move imports

move back imports to methods

remove whitespace from blank line

* Fix problem with using Traccar event (home-assistant#23543)

* Bump homekit_python to 0.14.0 (home-assistant#23562)

* Upgrade pysonos to 0.0.12 (home-assistant#23560)

* Clean up ZHA discovery logic (home-assistant#23563)

* use domain constants from HA

* cleanup endpoint processing in discovery

* Whitespace.

* Migrate tests to pytest (home-assistant#23544)

* Migrate tests to pytest

* Fixup

* Use loop fixture in test_check_config

* Lint

* bump zha-quirks version (home-assistant#23568)

* Add core APIs to migrate device identifiers and entity unique_id (home-assistant#23481)

* Add device identifiers migration

* Add entity unique_id migration

* Update per arch issue

* Move to existing update methods

* Essent sensor (home-assistant#23513)

* Initial commit for Essent

* Cleanup Essent component

* Update CODEOWNERS

* Move stuff to PyEssent

* Update requirements_all

* Fix PyEssent

* Move meter list to PyEssent library

* Update requirements_all

* Only check for updates once an hour

* Use PyEssent 0.10

* Fixing up Essent component

* Fix crash

* Don't add unused meter/tariff combos

* Fix lint

* Get tariffs per meter

* Don't hammer Essent API

* Fix linting errors

* Fix old description

* Fix old call

* Cleanup Essent component

* Upgrade discord.py to v1.0.1 (home-assistant#23523)

* Always pad mac addresses from nmap tracker with leading zeros (home-assistant#23492)

* Update mysensors sensor icons (home-assistant#23491)

* Add some icons.
* Sort sensor types according to mysensors serial api numbering.

* Add bypass and automatic bypass switch for Danfor Air. (home-assistant#23572)

Add bypass and automatic bypass switch for Danfoss Air

* Ptvsd debugger component. (home-assistant#23336)

* ptvsd debugger component.

* Add test case

* ptvsd as test dependency

* Fix for 3.5

* Fixed bootstrap test

* Use dict direct lookup.

* Don't need to load dependencies.

* Get the test working.

* 3.5 fix

* Set mock return value

* Put tests back, but skip them

* Change log level

* Fix min/max temp and humidity for homekit_controller climate (home-assistant#23421)

* Fix min/max temp and humidity for homekit_controller climate.

* Fix typo

* Fix failing state update tests (home-assistant#23575)

* render_with_collect method for template (home-assistant#23283)

* Make entity_filter be a modifiable builder

* Add render_with_collect method

* Use sync render_with_collect and non-class based test case

* Refactor: Template renders to RenderInfo

* Freeze with exception too

* Finish merging test changes

* Removed unused sync interface

* Final bits of the diff

* Upgrade youtube_dl to 2019.04.30 (home-assistant#23579)

* Set up CI with Azure Pipelines

[skip ci]

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Bumpped the pyeconet version (home-assistant#23578)

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Simplify Travis cache config (home-assistant#23592)

* Update azure-pipelines.yml for Azure Pipelines

* Fix low_battery_threshold issue HomeKit (home-assistant#23593)

* Redesign AlarmControlPanel for Homematic IP (home-assistant#23565)

* redesign AlarmControlPanel

* Fix lint

* Fixes after review

* Update azure-pipelines.yml for Azure Pipelines

* Ambiclimate (home-assistant#22827)

* Ambiclimate

* Ambiclimate

* style

* Add config flow to ambicliamte

* Add config flow to ambicliamte

* update requirements_all.txt

* ambiclimate

* tests

* typo

* ambiclimate

* coverage

* add manifest.json

* services

* codeowner

* req

* ambicliamte

* style

* ambicliamte

* add to requirements all tests

* add to requirements all tests

* .coveragerc

* Add tests

* add doc

* style

* fix test

* update tests

* update tests

* update tests

* update tests

* update tests

* tests

* tests

* fix comment

* Fix authentication issue (home-assistant#23600)

Update to pymy1 version 1.2.1 to fix authentication issue

* Move I/O to executor thread pool (home-assistant#23589)

* Move I/O to executor thread pool

* Check if image is in whitelist_external_dir

* Move import to top of file

* Fix bad indentation

* Update bomradarloop to v0.1.3 (home-assistant#23599)

* updated manifest.json with correct version of hangup (home-assistant#23596)

* Add and improve Homekit controller pairing messages and errors (home-assistant#23532)

* Be clear about pairing code format

* Handle more homekit errors while pairing

* Update en translation

* Fix log message feedback

* Added message to data_template at notify REST (home-assistant#23108)

* Added message to data_template at notify rest

* Added missing newlines

* Fixed unhandled exception in OpenUV data update (home-assistant#23611)

* Support STATE_AUTO in homekit_controller climate (home-assistant#23583)

* Fix unexpected error thrown if instance_domain is not set (home-assistant#23615)

* Bump pyheos (home-assistant#23616)

* Further improve IndieAuth redirect_uri lookup failure logs (home-assistant#23183)

* Don't create connections between sensors. Fixes home-assistant#22787 (home-assistant#23202)

* update geniushub client library to fix issue home-assistant#23444 (home-assistant#23450)

* Fix netatmo_public sensor to use netatmo authentication (home-assistant#23455)

* Bump pychromecast (home-assistant#23463)

* Fix cleanup of dynamic group (home-assistant#23475)

* Fix Hue sensors returning None value (home-assistant#23478)

* Only include agent user ID in SYNC responses (home-assistant#23497)

* Fix media_player alexa power control bug (home-assistant#23537)

* Fix problem with using Traccar event (home-assistant#23543)

* Fix authentication issue (home-assistant#23600)

Update to pymy1 version 1.2.1 to fix authentication issue

* Fix unexpected error thrown if instance_domain is not set (home-assistant#23615)

* Bump pyheos (home-assistant#23616)

* Bumped version to 0.92.2

* Add support for flow sensor metrics in RainMachine (home-assistant#23221)

* Initial commit

* In the clear

* Clean caldav calendar tests (home-assistant#23609)

* Improve sun automation tests (home-assistant#23588)

* Improve sun automation tests

* Lint

* Restore timezone after test

* Update pyvesync_v2 version to 0.9.7 (home-assistant#23603)

* Update azure-pipelines.yml for Azure Pipelines

* Update azure-pipelines.yml for Azure Pipelines

* Prevent turning on tellduslive lights with 0 brightness (home-assistant#23135)

* Prevent turning on tellduslive lights with 0 brightness

It was possible for the light compontent to get in a state where the last_brightness was set to zero, and when turning on (by calling turn_on) it would call the TellStick with 0 dim level, ergo not turning on the light.

With this, it will fall back on a 75% dim level if the level is set to zero.

* Wrap long log line over two lines

And using a more proper way of formatting the message

* Fallback to 100% instead of 75%

* Update docstrings (home-assistant#23624)

* Order imports (home-assistant#23623)

* Polling is default (home-assistant#23622)

* Updgrade Tibber library (home-assistant#23630)

* update tibber library

* update tibber library

* Loosen discovery config validation to avoid breaking changes (home-assistant#23625)

* Allow optional service handlers to be promoted to config flow without a breaking change

* Updated wording

* Remove period

* Update azure-pipelines.yml for Azure Pipelines

* Clean up redundant same-package ..package imports (home-assistant#23587)

* Upgrade pytest to 4.4.1 (home-assistant#23584)

* Upgrade mypy (home-assistant#23586)

* Upgrade mypy to 0.701

* Enable strict equality checks

* Strict equality error fixes

* StateMachine.is_state docstring fix

* Allow removing Telegram reply keyboard (home-assistant#23467)

*  Allow removing telegram reply keyboard by setting `keyboard` to an empty list

* Telegram keyboard: [] clearing in services.yaml

* Convert frontend to do client-side modern JS detection (home-assistant#23618)

* Convert frontend to do client-side async pick

* Further cleanup

* Updated frontend to 20190502.0

* Fix template caching

* Remove es5 test

* Lint

* Update description

* Further patch to fix of home-assistant#22890 (home-assistant#23627)

* Refactor evohome to prepare for water_heater (home-assistant#23489)

* refactor - add const.py, change order of propertys, methods

* import client at top of file

* remove debug line

* de-lint

* delint

* add me as CODEOWNER

* remove lint hint

* delint

* Extend play_media support (home-assistant#23580)

* update switchbot library (home-assistant#23643)

* Add "soc-thermal 1" as CPU Temp label to Glances (home-assistant#23635)

* deCONZ - Retry on BridgeBusy errors (home-assistant#23436)

* Added option to select photoblack cartridge (home-assistant#23433)

* Added option to select photoblack cartridge

* Update sensor.py

* Name change

* Fix bad request for some IP ONVIF camera (home-assistant#22972)

* Onvif camera improvements using zeep

* Fix static code checks

* Make obtain_input_uri async

* Convert several methods to async

* Fix static checks

* Fix static checks

* Fix requirements_all.txt

* Lint improvements

* Async services

* Use onvif-zeep-async and check if PTZ service is available before creating it

* Remove some hacks that are now defined in onvif-zeep-async

* Don't log input, it might contain sensitive information

* Static code analysis fixes

* Run requirements stuff

* Fix

* Remove suds requirement

* Onvif camera improvements using zeep

* Fix static code checks

* Make obtain_input_uri async

* Convert several methods to async

* Fix static checks

* Fix static checks

* Fix requirements_all.txt

* Lint improvements

* Async services

* Use onvif-zeep-async and check if PTZ service is available before creating it

* Remove some hacks that are now defined in onvif-zeep-async

* Don't log input, it might contain sensitive information

* Static code analysis fixes

* Run requirements stuff

* Fix

* Remove suds requirement

* Use dt_util.utcnow

* Platform setup should not have a return value

* Remove explicit dependency to zeep[async]

* Bump onvif-zeep-async to 0.1.2

* Update requirements_all.txt

* Add exception handling

* Fix static checks

* Don't catch generic exceptions

* Update camera.py

* Bump pyteleloisirs version (home-assistant#23661)

* Bump pyteleloisirs version

* requirements update

* Upgrade psutil to 5.6.2 (home-assistant#23671)

* Upgrade shodan to 1.13.0 (home-assistant#23675)

* Upgrade slacker to 0.13.0 (home-assistant#23672)

* Upgrade tapsaff to 0.2.1 (home-assistant#23676)

* Upgrade sqlalchemy to 1.3.3 (home-assistant#23674)

* Remove extraneous update call in SimpliSafe (home-assistant#23680)

* Upgrade pysnmp to 4.4.9 (home-assistant#23677)

* Upgrade spotcrime to 1.0.4 (fixes home-assistant#13189) (home-assistant#23679)

* Add Bizkaibus, Biscays (Spain) bus service component (home-assistant#22934)

* Updated to the current version of dev

* Added the component to .coveragerc

* Added __init__.py and manifest.json

* Changed the manifest to comply the json format

* Changes in for complete the PEP8 Code

* Fixed the api call to use PyPI package

* Fixed API correrct call

* Fixes for complete the requirements

* Added dependencies in manifest.json

* Changed the __init__.py to complete PEP8

* Simplified the __init__.py

* Runned codeowner script

* executed gen_requirements_all.py

* Direct call for dicts and unit changed to minutes

* Fixed the optional dict call, sorry, my bad, I did not that

* Deleted unused vars

* Changed optional parameter to required

* Remove blank first line

* Add HomeKit Television functionality  (home-assistant#22968)

* Clean and fix google calendar tests (home-assistant#23608)

* Clean and fix google calendar tests

* Extract test calendar constant for google test
* Rewrite google calendar tests
* Clean and fix google calendar tests
* Clean and fix google component tests
* Add google conftest
* Skip flaky google calendar test

* Fix google calendar bug

* Fix yield fixture

* Set fixture names to avoid lint warning

* Fix yield fixture

* Update requirements for pyvlx. (home-assistant#23694)

* Clean up mqtt device tracker tests (home-assistant#23700)

* Move mqtt device tracker test under mqtt dir

* Patch config file load and save

* Clean up

* Sort imports

* Put expected value last in assertions

* Clean up device tracker tests (home-assistant#23695)

* Clean up device tracker tests

* Fix async load config in device tracker tests.
* Clean up lint in device tracker tests.
* Sort device tracker tests imports.
* Patch config saving in device tracker tests.
* Rename fixture.
* Rename some tests that had long cryptic names.

* Replace calls  to device_tracker.async_setup

* Move Sonos services to sonos domain (home-assistant#23670)

* Move owntracks device tracker test under owntracks (home-assistant#23701)

* Add support for SET_AWAY_MODE and TURN_ON/OFF on Daikin Climate (home-assistant#23585)

* add support for on/off on daikin climate

* add support for away mode on daikin climate

* Bump ZHA modules versions. (home-assistant#23705)

* Bump ZHA modules versions.

Bump bellows-homeassistant version.
Bump zigpy-homeassistant version.
Bump zigpy-xbee-homeassistant version.

* Update requirements_*.txt

* Add additional single input cluster entries - ZHA (home-assistant#23697)

* more profiles

* remove from binary sensor profile

* remove sensor profile mapping

* Add media_type_app to media_player (home-assistant#23666)

* Add media_type_app

* Add MEDIA_TYPE_APP

* Bump 0.7.3

* Bump 0.7.3

* Bump 0.7.3

* typo

* Add a TCP timeout of 5 seconds to ffmpeg (home-assistant#23617)

Add a TCP timeout of 5 seconds to ffmpeg to fix stream getting stuck when network connectivity is lost
home-assistant#22741

* Bump pyheos to 0.5.2 (home-assistant#23708)

* Catch thethingsnetwork TypeError (home-assistant#23667)

* Catch TypeError (fixes home-assistant#23097)

* Re-add return values

* Update homeassistant/components/thethingsnetwork/sensor.py

Co-Authored-By: fabaff <mail@fabian-affolter.ch>

* Use local constant in Daikin for STATE_OFF (home-assistant#23712)

* Upgrade sendgrid to 6.0.5 (home-assistant#23711)

* bump zha-quirks (home-assistant#23714)

* Update IDs after firmware upgrade in HEOS (home-assistant#23641)

* Initial work

* Update tests

* huawei_lte: handle icons for None sensor values gracefully (home-assistant#23649)

* Use the URL provided by the Wink API for subscriptions. (home-assistant#23710)

* Use the URL provided by the Wink API for subscriptions.

* Changed python-wink version

* Upgrade switchbot , fixes home-assistant#23702 (home-assistant#23716)

* Fix SmartThings Samsung Air Conditioner Support (home-assistant#23706)

* Bump pysmartthings to 0.6.8

* Fix AC climate device

* Fix stale comment

* Share snmp constants across all platforms (home-assistant#23678)

* Share constants across all platforms

* Update .coveragerc

* Add TTL support and custom headers support. (home-assistant#22988)

* Add TTL custom support and custom headers support.

* fix pywebpush version

* removed whitespaces surrounding docstrings.

* fixes for tests

* priority option to data

* checking of ATTR_ENDPOINT

* change checking of target to vol.Schema

* more tests

* Added new binary sensor meteoalarm to get weather alerts in Europe (home-assistant#23663)

* Added new component meteoalarm

* Update sensor.py

* Update manifest.json

* Update manifest.json

* Update manifest.json

* Added file CODEOWNERS

* Modified some code, thanks @amelchio

* removed Throttle because is not being used anymore

* Update _attributes ad _state

* some cleanup

* Update sensor.py

Change sensor to binarysensor

* Rename sensor.py to binary_sensor.py

rename the file

* Update binary_sensor.py

Removed BinarySensorDevice from class

* Update binary_sensor.py

Made a mistake with BinarySensorDevice

* Update binary_sensor.py

clean up white spaces

* Update binary_sensor.py

Fix BinarySensorDevice

* Update binary_sensor.py

cleanup the import libs

* modified __init__

* fix

* final fix, thanks @amelchio

* forgot to change the sensor.py

* correct some typo in text

* fix typos

* fix another typo

* fix typo

* add abbreviation for current_temperature_template (home-assistant#23733)

* Add water_heater to geniushub, bump client library (home-assistant#23384)

* add water_heater

* add geniushub/water_heater.py

* de-lint

* de-lint 2

* remove temperature from device state attribs

* update to latest client library

* add me as CODEOWNER

* bump client

* bump client

* delint/refactor

* Update homeassistant/components/geniushub/water_heater.py

Co-Authored-By: zxdavb <david@bonnes.me>

* Add debug prints to sun (home-assistant#23598)

* Add debug prints to sun

* Review comment

* Add HEOS sign-in/out services (home-assistant#23729)

* Add HEOS sign-in/out services

* Fix typo in comment

* Fix Hue sensor integration with multiple bridges. (home-assistant#23713)

* Fix effects on HUE integration for Osram bulbs (home-assistant#22789)

* Fix hue effect for others

* New suggestion

* switched implementation to remove colorloop for osram bulbs

* Check ATTR_EFFECT in kwargs

* Fix  tests

* Upgrade aiodns to 2.0.0 (home-assistant#23743)

* Add abbreviation for position_topic (home-assistant#23740)

* Update PR template (home-assistant#23520)

* Update PR template

* Update config, PR template

* Add Intergas InComfort Lan2RF gateway (home-assistant#23736)

* fixed __init__.py

* add sensors

* switch to parent-child architecture

* make binary_sensor the parent

* revert parent - to water_heater

* first working version

* working, delinted (except TODO)

* update to latest client library

* remove debug code

* delint

* tweak device_state_attributes

* tweak device_state_attrbutes

* minor tweaks

* bump client library for bugfix

* improve state attributes for pumping

* update .coverage

* bugfix - binary sensors not updating

* rename to incomfort from intouch

* fix coveragerc regression

* bump client (bugfix for /protected URL)

* bump client (bugfix for /protected URL) 2

* bump client

* remove debug code

* ready for PR

* fix regression

* use xx._boiler instead of xx._objref

* improve current_temperature and delint

* use current_operation instead of state

* refactor vol.Schema

* remove unneeded instance attribute

* remove unneeded instance attribute 2

* refactor device_state_attributes

* change 'boiler' to 'heater'

* change 'boiler' to 'heater' 2

* correct a typo

* bugfix: add missing comma

* small tidy-up

* Fix upnp logger name (home-assistant#23724)

* Fix upnp logger name

* Fix more loggers

* Add update events to registries (home-assistant#23746)

* Add update events to registries

* Add to websocket

* Add integration step to onboarding (home-assistant#23732)

* Return an extra oauth2 auth code during onboarding

* Areas in const

* Add integration step

* Lint

* Fix tests

* Fix test

* Verify integration added to done

* Verify step is marked as done

* Updated frontend to 20190507.0

* Merge netatmo_public sensor into the netatmo integration (home-assistant#23531)

* Merge netatmo public into netatmo integration

* Remove netatmo_public platform

* Remove dev log messages

* Improve error handling

* Check config for unsupported conditions

* Fix linter

* Reduce nested blocks

* Upgrade numpy to 1.16.3 (home-assistant#23673)

* Upgrade Mastodon.py to 1.4.0 (home-assistant#23753)

* New cover platform for ADS integration (home-assistant#23377)

* new cover platform

* improve logging II

* remove dependencies

* fix comment

* fix review findings

* Update azure-pipelines.yml for Azure Pipelines

* Prompt for pin only on open / unlock (home-assistant#23751)

* Prompt for pin only on open / unlock

* Fixed test cases

* Upgrade defusedxml to 0.6.0 (home-assistant#23651)

* Refactor child validation (home-assistant#23482)

* Try to make the process more readable and paritioned.
* Validate child values using set message.
* Only validate using relevant schemas.
* Extract node validation.
* Rework const types and schemas.
* Rework child validator.
* Enhance warning logging message.

* Update Sesame component to use Candy House's library using the V3 API (home-assistant#23621)

* Update Sesame component to use Candy House's library using the V3 API

* Updated requirements_all.txt

* Fix pylint warning

* Revert back to ATTR_DEVICE_ID

* Upgrade zeroconf to 0.22.0 (home-assistant#23524)

* No longer rely on requests (home-assistant#23685)

* No longer rely on requests

* Lint

* Missed a few parts

* Fix types

* Fix more types

* Update __main__.py

* Fix tests

* Lint

* Fix script

* Update azure-pipelines.yml for Azure Pipelines

* Updated frontend to 20190508.0

* Update translations

* Version bump to 0.94.0.dev0

* Bump pyatmo to v1.11 (home-assistant#23766)

* Add Presence Detector Indoor to Homematic IP (home-assistant#23755)

* Add presence detector indoor

use device classes constants

* Add illuminance

* isort

* Split up yaml loaders into multiple files (home-assistant#23774)

* Start moving parts of yaml utils to own module

Move parts of yaml loader out of the single large file and start
to create the structure of the yaml loaders in Ansible [0].

[0]: https://github.com/ansible/ansible/tree/devel/lib/ansible/parsing/yaml

* Finish yaml migration, update tests and mocks

  * Move code around to finish the migration
  * Update the mocks so that `open` is patched in
    `homeassistant.util.yaml.loader` instead of
    `homeassistant.util.yaml`.
  * Updated mypy ignores
  * Updated external API of `homeasistant.util.yaml`, see below:

Checked what part of the api of `homeassistant.util.yaml` was actually
called from outside the tests and added an `__ALL__` that contains only
these elements.

Updated the tests so that references to internal parts of the API (e.g.
the yaml module imported into `homeassistant.util.yaml.loader`) are
referenced directly from `homeassistant.util.yaml.loader`.

In `tests/test_yaml.py` the import `yaml` refers to
`homeassistant.util.yaml` and `yaml_loader` refers to `~.loader`.

Future work that remains for the next iteration is to create a custom
SafeConstructor and refers to that instead of monkey patching `yaml` with
custom loaders.

* Update mocks in yaml dumper, check_config

* Add config entry for IQVIA (home-assistant#23765)

* Add config entry for IQVIA

* Updated tests and requirements

* Removed unnecessary dependency

* Fixed tests

* Reverted unintended change

* Add stepped volume to demo (home-assistant#23759)

* Add stepped volume to demo

* Simplify somewhat to avoid extra check

* Add battery binary sensor to homematic (home-assistant#23067)

* first proposal

* parameter rename

* retrigger CI

* remove separate binary sensor

* remove batter_sensor

* battery device distinction at binary sensor discovery

* Updated frontend to 20190509.0

* fix two times creating JWT headers. (home-assistant#23777)

* Sort discovered entries by 'st' to ensure getting the same device each discovery (home-assistant#23763)

* Beta Fix: ONVIF (home-assistant#23787)

* bump package to include wsdl

* update requirements all

* Fix for issue home-assistant#23739.  Added unique_id property so (home-assistant#23769)

that entities will always get mapped to the same
property ZPID code.

* Update sensor.py

* Bumped keenetic NDMS2 client version (home-assistant#23786)

* Add support for an external step in config flow (home-assistant#23782)

* Add support for an external step in config flow

* Types

* Lint

* Centralize geniushub updates (home-assistant#23764)

* add hub/parent/manager

* add hub/parent/manager 2

* working now

* delint

* add back water heater

* make water_heater a child

* make water_heater a child - delint

* make water_heater a child - delint 2

* improve turn_on logic, and small tidy-up

* improve turn_on logic 2

* improve turn_on logic 3 - better docstring

* improve turn_on logic 3 - better docstring

* remove unnecessary DICT.get()s

* remove unnecessary DICT.get()s 2

* code tidy-up

* de-lint

* refactor for GeniusData

* refactor for GeniusData 2

* code tidy-up

* add missing should_poll = False

* Move tests to right folder (home-assistant#23790)

* Move tests to right folder

* Fix test leaving files behind

* Synchronize Sonos service calls (home-assistant#23791)

* Updated frontend to 20190510.0

* Do not add coordinator to the ZHA entities. (home-assistant#23803)

* fix onvif wsdl import - take 2 (home-assistant#23807)

* Add LCN climate platform (home-assistant#22542)

* Add LCN climate component

* Updates of ha_state are done async

* Changes due to manifest.json

* Bump venstarcolortouch to v0.7 (home-assistant#23806)

* Upgrade youtube_dl to 2019.05.11 (home-assistant#23808)

* Bump pyotgw to 0.4b4, fix Opentherm Gateway name in manifest.json (home-assistant#23810)

* Fix patching right import (home-assistant#23816)

* Add incomfort climate and bump client (home-assistant#23830)

* Initial commit

* bump client for bugfix

* bump client for bugfix 2

* de-lint

* Make broadlink switch restore its state (home-assistant#23829)

* Make broadlink switch restore its state

Method copied from pilight switch

* style

* Catch import error when processing config (home-assistant#23833)

* Remove badges from README [skipci] (home-assistant#23815)

* HomeKit Controller: Adopt config entries for pairing with homekit accessories (home-assistant#23825)

* Fix user initiated pairing + show more user friendly name

* Add lock around async_refresh_entity_map

* Migrate homekit_controller to config entries.

* Improve docstring

Co-Authored-By: Martin Hjelmare <marhje52@kth.se>

* Add dummy async_setup_platform

* add_service -> async_add_service

* Add missing returns

* Enable coverage checks for homekit_controller

* Automatically generate config flow list (home-assistant#23802)

* Add config flow to manifest.json

* Still load config flows via config flow platform

* Fix typo

* Lint

* Update config_flows.py"

* Catch import error when setting up entry

* Lint

* Fix tests

* Fix imports

* Lint

* Fix Unifi tests

* Fix translation test

* Add homekit_controller config flow

* Add new SmartHab light and cover platform (home-assistant#21225)

* Add SmartHab platform

* Remove url config entry, improve error handling

* Upgrade smarthab dependency

* Address comments

* Lint

* Daikin adaptions for AirBase units (home-assistant#23734)

* updated list of supported fan_modes

* AirBase units does not support Holiday-mode

* AirBase units does not support outside temp

* pydaikin version bump

* don't modify constant

* Fix zha timed off (home-assistant#23849)

* Fix for battery device: new_device referenced before assignment. (home-assistant#23793)

* Fix for battery device: new_device referenced before assignment.

* Fix buttons and switches mixup

* Update __init__.py

* Update binary_sensor.py

* Update __init__.py

* Update __init__.py

* Update binary_sensor.py

* Update __init__.py

* Update binary_sensor.py

* typo and indentation fixes

* low_bat and lowbat to uppercase.

* Better handle large amounts of data being sent over WS (home-assistant#23842)

* Better handle large amounts of data being sent over WS

* Lint

* Zeroconf - replace library (home-assistant#23835)

* Use aiozeroconf in preparation for new zeroconf discovery

* Update requirements

* Remove sleep

* Make stop zeroconf a coroutine

* Remove unused import

* Fix aiozeroconf dependency in default_config tests

* WS: Improve service calling errors (home-assistant#23840)

* WS: Improve service calling errors

* Docstyle

* Types

* Update text

* Updated frontend to 20190514.0

* bump zha-quirks (home-assistant#23855)

* Fix ZHA battery when readings produce an unknown value (home-assistant#23854)

* check for unknown readings

* only publish valid readings

* remove unused constant

* Correct ZHA illumination conversion (home-assistant#23853)

* fix illumination values

* correct formula

* update illuminance calculation

* update test

* Fix improper usage of body attribute on web.Response. Should be text since we arent sending bytes (home-assistant#23857)

* Allow deletion of automations and scripts (home-assistant#23845)

* Update azure-pipelines.yml for Azure Pipelines

Automated version updates

* Use Cloudhooks for OwnTracks (home-assistant#23847)

* Use Cloudhooks for OwnTracks

* Update config_flow.py

* Update config_flow.py

* Fix aiohttp response serialize (home-assistant#23858)

* Fix aiohttp response serialize

* Suport bytes

* Handle None

* Add geniushub sensor and binary_sensor (home-assistant#23811)

* Initial commit

* add lastComms and de-lint

* dummy commit

* dummy commit 2

* refactor to temp in favour of battery

* back to battery, and no temp

* use snake_case

* Bump client

* only v3 API exposes device attributes

* delint

* delint2

* Change GeniusSwitch to GensiusBinarySensor

* Quiet the chatty sun.sun (home-assistant#23832)

* Split up method to allow caching event

* Lower frequency of updates.

* Code review patches.

* Minor changes to test

* Skip end of period at fixed multiple of delta.
Improved documentation.

* Take code owner for sun.sun (home-assistant#23877)

* Take code owner

* Post hassfest

* Fix homekit test assert no messages (home-assistant#23856)

* Fix auto discovery if the monitor condition (home-assistant#23880)

* Restructure device tracker (home-assistant#23862)

* Restructure device tracker

* Docstyle

* Fix typing

* Lint

* Lint

* Fix tests

* Update Pynetgear to v0.6.1 (home-assistant#23886)

* Update Pynetgear to v0.6.1

* update pynetgear to v0.6.1

* Fix PS4 blocking startup (home-assistant#23893)

* Fix Hassio-version for Azure Pipelines (home-assistant#23895)

* Update azure-pipelines.yml for Azure Pipelines

* Fix ecobee 3 homekit pairing (home-assistant#23882)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.