Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set myself as codeowner of xmpp, removed me from notify/* #23207

Merged
merged 2 commits into from Apr 18, 2019

Conversation

Projects
None yet
4 participants
@flowolf
Copy link
Contributor

commented Apr 18, 2019

fix CODEOWNERS as suggested by @robbiet480

@robbiet480
Copy link
Member

left a comment

You need to make these changes in the integration manifest files as well since CODEOWNERS is automatically generated from the manifest files.

Also, did you not want to add yourself to yesssms?

@flowolf flowolf requested a review from fabaff as a code owner Apr 18, 2019

@flowolf

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

changed the manifests, and I am already codeowner of yessssms; so that's fine.

@codeowners-notifier

This comment has been minimized.

Copy link

commented Apr 18, 2019

Hey there @fabaff, mind taking a look at this pull request as its been labeled with a integration (xmpp) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@robbiet480 robbiet480 merged commit daf2f30 into home-assistant:dev Apr 18, 2019

2 of 3 checks passed

ci/circleci: static-check Your tests are queued behind your running builds
Details
build Workflow: build
Details
cla-bot Everyone involved has signed the CLA

@balloob balloob referenced this pull request May 14, 2019

Merged

0.93.0 #23864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.