Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change configuration for orangepi #23231

Merged
merged 1 commit into from Apr 19, 2019

Conversation

Projects
None yet
3 participants
@pascallj
Copy link
Contributor

commented Apr 19, 2019

Description:

Words should be separated by underscores as @MartinHjelmare requested. Please merge before component goes public to avoid confusion.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9252

Example entry for configuration.yaml (if applicable):

# Example configuration.yaml entry
binary_sensor:
  - platform: orangepi_gpio
    pin_mode: pc
    ports:
      11: PIR Office
      12: PIR Bedroom

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@MartinHjelmare
Copy link
Member

left a comment

Thanks!

@pascallj pascallj referenced this pull request Apr 19, 2019

Merged

Change configuration for orangepi #9252

2 of 2 tasks complete
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

The orangepi integration will go out in 0.93. So we can safely just merge this PR to dev, and it will go out in 0.93 too.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

Can be merged when build passes.

@MartinHjelmare MartinHjelmare merged commit b2a7699 into home-assistant:dev Apr 19, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 3e443d2...500586e
Details
codecov/project 94.29% (target 90%)
Details

@pascallj pascallj deleted the pascallj:patch-1 branch Apr 19, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request Apr 19, 2019

Merge branch 'dev' into current
* dev: (401 commits)
  Drop unnecessary block_till_done, improve tests (home-assistant#23247)
  Drop unnecessary block_till_done, improve tests (home-assistant#23246)
  Name sensors correctly (home-assistant#23208)
  Avoid calling async code in sync context (home-assistant#23235)
  Add accuracy and status for Traccar (home-assistant#23180)
  Add more CPU temp. labels to Glances (home-assistant#23179)
  Add missing service for persistent_notification (home-assistant#23230)
  Review feedback from home-assistant#23191 (home-assistant#23233)
  Add and use an async_fire_service_discovered helper (home-assistant#23232)
  Change configuration for orangepi (home-assistant#23231)
  Hass.io Add-on panel support for Ingress (home-assistant#23185)
  Remove archived 17track packages from the entity registry (home-assistant#23049)
  Async fix for bluetooth stopping (home-assistant#23225)
  Fix clearing error message for MQTT vacuum (home-assistant#23206)
  Set default value for input_datetime (home-assistant#21919)
  Fix optimistic mode + other bugs, tests (home-assistant#22976)
  Only comment with changed coverage on release PRs [skip-ci] (home-assistant#23224)
  Add json_attributes_template (home-assistant#22981)
  Remove copy paste error
  update zha-quirks (home-assistant#23215)
  ...

@balloob balloob referenced this pull request May 14, 2019

Merged

0.93.0 #23864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.