Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unnecessary block_till_done, improve tests for MQTT Climate tests #23249

Merged
merged 1 commit into from Apr 19, 2019
Merged

Drop unnecessary block_till_done, improve tests for MQTT Climate tests #23249

merged 1 commit into from Apr 19, 2019

Conversation

emontnemery
Copy link
Contributor

Description:

Drop unnecessary block_till_done, improve tests for MQTT Climate tests

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@awarecan awarecan merged commit 5572112 into home-assistant:dev Apr 19, 2019
MartinHjelmare
MartinHjelmare reviewed Apr 19, 2019
View reviewed changes
tests/components/mqtt/test_climate.py
entity_id=ENTITY_CLIMATE)
await hass.async_block_till_done()
state = hass.states.get(ENTITY_CLIMATE)
print(state.attributes)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale debug print.

@emontnemery emontnemery deleted the mqtt_improve_tests_climate branch April 28, 2019 09:27
@balloob balloob mentioned this pull request May 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

Assignees
No one assigned
Labels
cla-signed core has-tests small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@emontnemery @MartinHjelmare @awarecan @homeassistant