Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unnecessary block_till_done for MQTT Light tests #23250

Merged
merged 1 commit into from Apr 19, 2019

Conversation

Projects
None yet
3 participants
@emontnemery
Copy link
Contributor

commented Apr 19, 2019

Description:

Drop unnecessary block_till_done for MQTT Light tests

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@emontnemery emontnemery changed the title Drop unnecessary block_till_done for MQTT Fan Drop unnecessary block_till_done for MQTT Light Apr 19, 2019

@emontnemery emontnemery changed the title Drop unnecessary block_till_done for MQTT Light Drop unnecessary block_till_done for MQTT Light tests Apr 19, 2019

@awarecan awarecan merged commit 416af5c into home-assistant:dev Apr 19, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing c899e2a...00f27e0
Details
codecov/project 94.3% (target 90%)
Details

mxworm added a commit to mxworm/home-assistant that referenced this pull request Apr 21, 2019

Merge branch 'dev' into current
* dev:
  Upgrade pyotp to 2.2.7 (home-assistant#23274)
  Upgrade xmltodict to 0.12.0 (home-assistant#23277)
  Add ctags file to .gitignore (home-assistant#23279)
  Bump zigpy and zigpy-xbee (home-assistant#23275)
  Bump zigpy-deconz (home-assistant#23270)
  Update pyheos and log service errors in HEOS integration (home-assistant#23222)
  Updated frontend to 20190419.0
  Return 0 instead of None (home-assistant#23261)
  Drop unnecessary block_till_done (home-assistant#23256)
  Drop unnecessary block_till_done, improve tests for MQTT Cover tests (home-assistant#23255)
  Drop unnecessary block_till_done for MQTT tests (home-assistant#23254)
  Drop unnecessary block_till_done for MQTT fan tests (home-assistant#23253)
  Added component named switcher_kis switcher water heater integration. (home-assistant#22325)
  Add missing services.yaml file for hue (home-assistant#23217)
  Drop unnecessary block_till_done, improve tests (home-assistant#23252)
  Drop unnecessary block_till_done (home-assistant#23251)
  Ask users for a pin when interacting with locks/garage doors (home-assistant#23223)
  Drop unnecessary block_till_done (home-assistant#23250)
  Drop unnecessary block_till_done, improve tests (home-assistant#23249)
  Drop unnecessary block_till_done, improve tests (home-assistant#23248)

@emontnemery emontnemery deleted the emontnemery:mqtt_improve_tests_light branch Apr 28, 2019

@balloob balloob referenced this pull request May 14, 2019

Merged

0.93.0 #23864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.