Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position is reversed for horizontal awnings #23257

Merged
merged 6 commits into from Jun 11, 2019

Conversation

@kbickar
Copy link
Contributor

commented Apr 19, 2019

Description:

Tahoma covers that are awnings are treated differently than other covers such as blinds. The "open" state of the awning is fully extended while closed is retracted.

Also added appropriate device classes

Related issue (if applicable): fixes #16868

Breaking Change: Tahoma horizontal awnings 'open' and 'closed' positions reversed

@ghost

This comment has been minimized.

Copy link

commented Apr 19, 2019

Hey there @philklei, mind taking a look at this pull request as its been labeled with a integration (tahoma) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

kbickar added 2 commits Apr 19, 2019
kbickar added 3 commits Apr 19, 2019

@kbickar kbickar closed this Apr 20, 2019

@kbickar kbickar reopened this Apr 20, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 20, 2019

Codecov Report

Merging #23257 into dev will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #23257     +/-   ##
=========================================
- Coverage   94.29%   94.19%   -0.1%     
=========================================
  Files         458      453      -5     
  Lines       37160    36917    -243     
=========================================
- Hits        35040    34775    -265     
- Misses       2120     2142     +22
Impacted Files Coverage Δ
homeassistant/components/mqtt/fan.py 74.19% <0%> (-23.78%) ⬇️
homeassistant/components/hue/bridge.py 73.07% <0%> (-1%) ⬇️
homeassistant/components/hassio/auth.py 90.47% <0%> (-0.44%) ⬇️
homeassistant/helpers/service.py 91.58% <0%> (-0.4%) ⬇️
homeassistant/components/hassio/handler.py 95.52% <0%> (-0.13%) ⬇️
homeassistant/components/cloud/http_api.py 99.01% <0%> (ø) ⬆️
homeassistant/components/hassio/const.py 100% <0%> (ø) ⬆️
homeassistant/components/google_assistant/const.py 100% <0%> (ø) ⬆️
homeassistant/components/hassio/addon_panel.py
homeassistant/components/hue/sensor_base.py
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c899e2a...04f0919. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Apr 20, 2019

Codecov Report

Merging #23257 into dev will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #23257     +/-   ##
=========================================
- Coverage   94.29%   94.19%   -0.1%     
=========================================
  Files         458      453      -5     
  Lines       37160    36917    -243     
=========================================
- Hits        35040    34775    -265     
- Misses       2120     2142     +22
Impacted Files Coverage Δ
homeassistant/components/mqtt/fan.py 74.19% <0%> (-23.78%) ⬇️
homeassistant/components/hue/bridge.py 73.07% <0%> (-1%) ⬇️
homeassistant/components/hassio/auth.py 90.47% <0%> (-0.44%) ⬇️
homeassistant/helpers/service.py 91.58% <0%> (-0.4%) ⬇️
homeassistant/components/hassio/handler.py 95.52% <0%> (-0.13%) ⬇️
homeassistant/components/cloud/http_api.py 99.01% <0%> (ø) ⬆️
homeassistant/components/hassio/const.py 100% <0%> (ø) ⬆️
homeassistant/components/google_assistant/const.py 100% <0%> (ø) ⬆️
homeassistant/components/hassio/addon_panel.py
homeassistant/components/hue/sensor_base.py
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c899e2a...04f0919. Read the comment docs.

@fabaff fabaff changed the title Position is reversed for awnings Position is reversed for wanings Apr 21, 2019

@kbickar kbickar changed the title Position is reversed for wanings Position is reversed for horizontal awnings Apr 22, 2019

@balloob
Copy link
Member

left a comment

Please add a comment for the breaking change section.

@balloob balloob merged commit d041c62 into home-assistant:dev Jun 11, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing c899e2a...04f0919
Details
codecov/project 94.19% (target 90%)
Details

@kbickar kbickar deleted the kbickar:tahoma-cover branch Jun 12, 2019

@balloob balloob referenced this pull request Jun 26, 2019
@pascalsaul

This comment has been minimized.

Copy link

commented Jun 29, 2019

Please revert the PR since it's breaking everything. All was good before so there was no reason to change this. Also three issues for the same introduced bug reported. The HorizontalAwning is different so that's why we made an exception last year to get it to work in HA.

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Jun 29, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.