Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove historical allergen and asthma sensors from IQVIA #23258

Merged
merged 3 commits into from Apr 27, 2019

Conversation

Projects
None yet
3 participants
@bachya
Copy link
Contributor

commented Apr 19, 2019

Breaking Change:

The IQVIA component no longer provides historical data for allergen and asthma conditions. Tactically, this means all historical sensors – including "Yesterday" sensors – will no longer appear; users will need to update any automations that previously relied on these sensors.

Description:

Per #23052 (comment), the IQVIA component should not store historical data; therefore, it removes historical allergen and asthma sensors.

Related issue (if applicable): N/A

Pull request in home-assistant.io with documentation (if applicable): TBD

Example entry for configuration.yaml (if applicable):

iqvia:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

@bachya bachya self-assigned this Apr 19, 2019

@bachya bachya force-pushed the bachya:iqvia-remove-historical branch 2 times, most recently from a0cfd24 to 7bb3c0f Apr 24, 2019

@bachya bachya marked this pull request as ready for review Apr 25, 2019

@bachya bachya changed the title Remove historical allergen and asthma sensors from IQVIA WIP: Remove historical allergen and asthma sensors from IQVIA Apr 25, 2019

@bachya bachya force-pushed the bachya:iqvia-remove-historical branch 3 times, most recently from 7645c15 to 40947c4 Apr 25, 2019

bachya added some commits Apr 19, 2019

@bachya bachya force-pushed the bachya:iqvia-remove-historical branch from 40947c4 to 92f1056 Apr 26, 2019

@bachya bachya changed the title WIP: Remove historical allergen and asthma sensors from IQVIA Remove historical allergen and asthma sensors from IQVIA Apr 26, 2019

@bachya bachya requested a review from MartinHjelmare Apr 26, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

Please write the breaking change paragraph so we can just copy paste it into the release notes. Explain what the breaking change is and what the user needs to do to cope with the breaking change.

Don't say:

This PR removes ...

Say:

Historical allergen and asthma sensors have been removed. Users will need to update any automations etc that are referencing the removed sensor entity ids.

The integration name will automatically be included in the header so it's not necessary to include that in the paragraph.

See some good and bad examples here:
https://www.home-assistant.io/blog/2019/04/24/release-92/#breaking-changes

@bachya

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

@MartinHjelmare Awesome! Thanks for tipping me off. I'll update to better verbiage.

FYI, per your note in #23052, I've removed all of the "Yesterday" sensors that were present here, as well.

@bachya bachya merged commit bf050ad into home-assistant:dev Apr 27, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 8fe95f4...bb24d77
Details
codecov/project 94.29% (target 90%)
Details

@bachya bachya deleted the bachya:iqvia-remove-historical branch Apr 27, 2019

@balloob balloob referenced this pull request May 14, 2019

Merged

0.93.0 #23864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.