Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Camera platform for buienradar imagery #23358
This idea was inspired by #22816. Most of the current PR's functionality could be provided by a generic IP camera using the given URL from
The main contribution of this PR is that it caches images for the given
This behaviour is verified in the test. When testing the PR manually this situation can be exacerbate by adding an
In addition it adds the camera component by implicitly documenting the URL. Factoring out the http request to a PyPI package would create a trivial package which would hardly be re-usable since it needs aiohttp passed in and would return
Alternatively the improved re-entrant behaviour could be added to the Generic IP camera and the radar imagery URL documented in the
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here> to be added after discussion on the PR's utility.
Example entry for
Apr 25, 2019
I think for as far as the changes are up to me this PR is done. What is left is removing the
An optional feature is configurable image size (
Let's give upstream mjj4791/python-buienradar#7 some time to be merged…
Any updates on this?
Also, on a related matter (being very, very offtopic here, apologies): the buienalarm on Android (I suppose it uses the same data source?) is the best weather app I have used. The graph (as implemented here to my understanding, to see when it's safe to go out again) and especially it's alarms ("It starts to rain in 25 minutes and continues for 40 minutes") are awesome. So my question is, would it be possible to extend this further to include the alarms (probably in a separate PR, though)?