Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tox.ini lint target #23359

Merged
merged 1 commit into from Apr 25, 2019

Conversation

Projects
None yet
3 participants
@ViViDboarder
Copy link
Contributor

commented Apr 24, 2019

tox fails due to being unable to reference the script module when
trying to run script/gen_requirements_all.py. Instead it needs to be
run as a module.

This was found while I was debugging #20197

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
Fix tox.ini lint target
tox fails due to being unable to reference the `script` module when
trying to run `script/gen_requirements_all.py`. Instead it needs to be
run as a module.
@ViViDboarder

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

@@ -32,7 +32,7 @@ commands =
deps =
-r{toxinidir}/requirements_test.txt
commands =
python script/gen_requirements_all.py validate
python -m script.gen_requirements_all validate

This comment has been minimized.

Copy link
@balloob

balloob Apr 25, 2019

Member

Ah, this is probably because of importing things from hassfest.

@balloob

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

Thanks!

@balloob balloob merged commit 6fb5b84 into home-assistant:dev Apr 25, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 96735e4...1d37c60
Details
codecov/project 94.31% (target 90%)
Details

@balloob balloob referenced this pull request May 14, 2019

Merged

0.93.0 #23864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.