Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for deprecated Sonos configuration #23385

Merged
merged 1 commit into from Apr 26, 2019

Conversation

Projects
None yet
4 participants
@amelchio
Copy link
Contributor

commented Apr 25, 2019

Breaking Change:

Configuring the Sonos integration as a media_player: platform in configuration.yaml was deprecated in 0.72 and has now been removed.

Description:

This cleans up the Sonos setup:

  • Remove setup_platform support
  • Remove discovery_info support that is never used because we now just prompt to set up a config entry
  • Move config schema to the component (so the config is actually validated)
  • Use cv.ensure_list_csv to split hosts

I did not want to update all the old tests that depended on the deprecated config so I started over with fixtures (which I don't know much about, so I kept it small for now).

Example entry for configuration.yaml (if applicable):

sonos:
  media_player:
    hosts:
      - 192.0.2.25
      - 192.0.2.26

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.

@amelchio amelchio force-pushed the amelchio:sonos-obsolete-old-config branch from 70d92a6 to 3f646f3 Apr 25, 2019

@amelchio amelchio merged commit 5dbf58d into home-assistant:dev Apr 26, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 39932d1...3f646f3
Details
codecov/project 94.3% (target 90%)
Details

mxworm added a commit to mxworm/home-assistant that referenced this pull request Apr 26, 2019

Merge branch 'dev' into current
* dev: (65 commits)
  Remove support for deprecated Sonos configuration (home-assistant#23385)
  Add missing feature support flag (home-assistant#23417)
  Fix supported features gates in media_player volume up/down services (home-assistant#23419)
  restore battery_quantity for zha devices (home-assistant#23320)
  Bump requirement to v55 (home-assistant#23410)
  Broadlink fixup unintended breakage from service refactor (home-assistant#23408)
  Add device info for Logi Circle camera and sensor entities (home-assistant#23373)
  Add Types to Homematic IP (home-assistant#23401)
  check if sabotage attr is in device (home-assistant#23397)
  add key parameter (home-assistant#23381)
  Bump youtube-dl version to 2019.04.24 (home-assistant#23398)
  Add device classes for media player and map to google types (home-assistant#23236)
  Add error handling for migration failure (home-assistant#23383)
  Update xiaomi library (home-assistant#23391)
  async_setup_component stage_1_domains (home-assistant#23375)
  Convert some test helpers to coroutines and adjust tests (home-assistant#23352)
  Add amcrest camera services and deprecate switches (home-assistant#22949)
  Fix race condition. (home-assistant#21244)
  Add media player external url (home-assistant#23337)
  Bump pyheos to 0.4.1 (home-assistant#23360)
  ...

# Conflicts:
#	homeassistant/components/homematicip_cloud/climate.py

@amelchio amelchio referenced this pull request Apr 27, 2019

Merged

Continuous discovery of Sonos speakers #23484

3 of 3 tasks complete

@balloob balloob referenced this pull request May 14, 2019

Merged

0.93.0 #23864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.