Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadlink fixup unintended breakage from service refactor #23408

Merged
merged 4 commits into from Apr 26, 2019

Conversation

@elupus
Copy link
Contributor

elupus commented Apr 25, 2019

Description:

Restore allowing host for services calls and pad packets

Related issue (if applicable): fixes #18453

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
elupus added 2 commits Apr 25, 2019
This matches switch config and is a regression fix
@ghost

This comment has been minimized.

Copy link

ghost commented Apr 25, 2019

Hey there @Danielhiversen, mind taking a look at this pull request as its been labeled with a integration (broadlink) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@elupus

This comment has been minimized.

Copy link
Contributor Author

elupus commented Apr 25, 2019

If i want this into a fixup release for current release do i need to do anything special. It's a pointless regression.

elupus added 2 commits Apr 25, 2019
@balloob balloob added this to the 0.92.1 milestone Apr 25, 2019
@andrewsayre andrewsayre merged commit 7d5c1ed into home-assistant:dev Apr 26, 2019
13 checks passed
13 checks passed
build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 39932d1...ca4fd2a
Details
codecov/project 94.31% (target 90%)
Details
pvizeli added a commit that referenced this pull request Apr 26, 2019
* Allow host/ipv6 address for broadlink service

This matches switch config and is a regression fix

* Restore padding of packets for broadlink

* Drop unused import

* Fix comment on test
@pvizeli pvizeli mentioned this pull request Apr 26, 2019
@elupus elupus deleted the elupus:broadlink_fixup branch May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.