Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning that honeywell/EU is to be deprecated #23469

Merged
merged 2 commits into from Apr 27, 2019
Merged

Add a warning that honeywell/EU is to be deprecated #23469

merged 2 commits into from Apr 27, 2019

Conversation

zxdavb
Copy link
Contributor

@zxdavb zxdavb commented Apr 27, 2019

Description:

The honeywell component actually contains two mutually-exclusive integrations, based upon either the somecomfort (US) or evohome-client (EU) client libraries. The evohome functionality is better provided in the evohome component, which uses the same client library.

This PR will add a warning to users of the honeywell component that support for EU-based systems is deprecated in favour of the evohome component.

This warning does not apply to / will not be seen by users of US-based systems.

Related issue (if applicable): None

Pull request in home-assistant.io with documentation (if applicable): None

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices: N/A

  • Tests have been added to verify that the new code works.

Copy link
Contributor

@amelchio amelchio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably adding a specific (not too distant) version number could speed up migrations.

homeassistant/components/honeywell/climate.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants