Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Minio component #23567

Merged
merged 35 commits into from Aug 20, 2019

Conversation

@tkislan
Copy link
Contributor

commented Apr 30, 2019

Description:

Reference issue: #20187

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9267

Example entry for configuration.yaml (if applicable):

minio:
  host: localhost
  port: 9000
  access_key: SO9KNO6YT9OGE39PQCZW
  secret_key: EzH5iGs3qbJr1MwIMf2AUyfqzewgd2qgrk9+i+vU
  secure: false
  listen:
    - bucket: test

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
tkislan added 13 commits Apr 21, 2019

@tkislan tkislan marked this pull request as ready for review Apr 30, 2019

@tkislan tkislan referenced this pull request Apr 30, 2019
9 of 10 tasks complete

@robmarkcole robmarkcole requested a review from MartinHjelmare May 1, 2019

homeassistant/components/minio/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/minio/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/minio/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/minio/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/minio/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/minio/minio_helper.py Outdated Show resolved Hide resolved
tkislan added 2 commits May 2, 2019
tkislan added 5 commits May 2, 2019
@codecov

This comment was marked as off-topic.

Copy link

commented May 8, 2019

Codecov Report

Merging #23567 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev   #23567      +/-   ##
=========================================
+ Coverage   93.9%    93.9%   +<.01%     
=========================================
  Files        464      464              
  Lines      37908    37908              
=========================================
+ Hits       35598    35599       +1     
+ Misses      2310     2309       -1
Impacted Files Coverage Δ
homeassistant/components/uk_transport/sensor.py 94.16% <0%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b30afde...bc138af. Read the comment docs.

@tkislan

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

Again, everything resolved.

@tkislan

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

@MartinHjelmare
Is anything blocking this?

homeassistant/components/minio/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/minio/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/minio/minio_helper.py Outdated Show resolved Hide resolved
homeassistant/components/minio/minio_helper.py Outdated Show resolved Hide resolved
tests/components/minio/test_minio.py Outdated Show resolved Hide resolved
tests/components/minio/test_minio.py Show resolved Hide resolved
tests/components/minio/test_minio_helper.py Outdated Show resolved Hide resolved
tests/components/minio/test_minio_helper.py Outdated Show resolved Hide resolved
@robmarkcole

This comment has been minimized.

Copy link
Contributor

commented Jun 22, 2019

Chaps what happened to this PR - looks very close to merge?

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

I'm happy to hear a second opinion from another member.

@robmarkcole

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

OK I am sitting on the fence with my comment about the tests but if thats all thats holding this up lets just make a decision and go with it

@dgomes
Copy link
Contributor

left a comment

I'm with @MartinHjelmare on the test issue

homeassistant/components/minio/minio_helper.py Outdated Show resolved Hide resolved
homeassistant/components/minio/minio_helper.py Outdated Show resolved Hide resolved
homeassistant/components/minio/minio_helper.py Outdated Show resolved Hide resolved
homeassistant/components/minio/minio_helper.py Outdated Show resolved Hide resolved
@tkislan tkislan referenced this pull request Jun 30, 2019
2 of 2 tasks complete

@MartinHjelmare MartinHjelmare added this to Review in progress in Dev Jul 23, 2019

@robmarkcole

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

ping @tkislan just a couple of changes required

tkislan added 5 commits Aug 18, 2019
@tkislan

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

Removed the tests in question ...
Updated formatting

Tests are currently failing because bimmer-connected package version 0.5.6 got taken down from pypi for some reason

@robmarkcole robmarkcole requested a review from MartinHjelmare Aug 19, 2019

@MartinHjelmare
Copy link
Member

left a comment

Thanks!

Dev automation moved this from Review in progress to Reviewer approved Aug 20, 2019

@MartinHjelmare MartinHjelmare merged commit eee2b2d into home-assistant:dev Aug 20, 2019

11 checks passed

CI Build #20190819.28 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 15ab004...4545a58
Details
codecov/project 94.02% (target 90%)
Details

Dev automation moved this from Reviewer approved to Done Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5 participants
You can’t perform that action at this time.