Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up redundant same-package ..package imports #23587

Merged
merged 1 commit into from May 2, 2019

Conversation

Projects
None yet
3 participants
@scop
Copy link
Contributor

commented May 1, 2019

Description:

SSIA, probably leftovers from tree restructuring.

Checklist:

  • The code change is tested and works locally (huawei_lte only).
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented May 1, 2019

Was circleci cancelled on purpose?

@scop

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

I stopped using circleci for my own builds, I had no idea that canceling a build there could possibly result in the cancellation being visible here as well (it says it's the scop->home-assistant project, not home-assistant->home-assistant). Well assuming that's what happened because circleci says I cancelled it.

I'll see if I can somehow restart the build (probably need to re-enable circleci for myself then ;(, at least temporarily).

@scop

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

Ok, it seems to be in progress now, let's see how it goes. BTW, see #23584 for some more circleci oddity.

@scop

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

CircleCI has marked test 3.6 as failed, but AFAICT everything except the end result there is green/success, 0 failures. Oh well.

@scop scop merged commit 0a75a2c into home-assistant:dev May 2, 2019

10 checks passed

ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA

@scop scop deleted the scop:relative-import-cleanups branch May 2, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request May 2, 2019

Merge branch 'dev' into current
* dev: (113 commits)
  Allow removing Telegram reply keyboard (home-assistant#23467)
  Upgrade mypy (home-assistant#23586)
  Upgrade pytest to 4.4.1 (home-assistant#23584)
  Clean up redundant same-package ..package imports (home-assistant#23587)
  Update azure-pipelines.yml for Azure Pipelines
  Loosen discovery config validation to avoid breaking changes (home-assistant#23625)
  Updgrade Tibber library (home-assistant#23630)
  Polling is default (home-assistant#23622)
  Order imports (home-assistant#23623)
  Update docstrings (home-assistant#23624)
  Prevent turning on tellduslive lights with 0 brightness (home-assistant#23135)
  Update azure-pipelines.yml for Azure Pipelines
  Update azure-pipelines.yml for Azure Pipelines
  Update pyvesync_v2 version to 0.9.7 (home-assistant#23603)
  Improve sun automation tests (home-assistant#23588)
  Clean caldav calendar tests (home-assistant#23609)
  Add support for flow sensor metrics in RainMachine (home-assistant#23221)
  Bump pyheos (home-assistant#23616)
  Fix unexpected error thrown if instance_domain is not set (home-assistant#23615)
  Support STATE_AUTO in homekit_controller climate (home-assistant#23583)
  ...

@balloob balloob referenced this pull request May 14, 2019

Merged

0.93.0 #23864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.