Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Sonos services to sonos domain #23670

Merged
merged 1 commit into from May 5, 2019

Conversation

Projects
None yet
4 participants
@amelchio
Copy link
Contributor

commented May 4, 2019

Breaking Change:

  • Sonos-specific services have been moved from the media_player domain to the sonos domain. For example, media_player.sonos_join has become sonos.join.
  • Services sonos.set_sleep_timer, sonos.clear_sleep_timer, sonos.update_alarm and sonos.set_option now require the entity_id parameter and will not target all when it is missing. You can use all to target all.

Description:

Move Sonos services to sonos domain.

While we are breaking things anyway, I added support for ENTITY_MATCH_ALL though I made it optional for join/snapshot services where it is common to target all.

Related issue (if applicable): fixes #15089

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9380

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

@andrewsayre
Copy link
Member

left a comment

Nice job!

@andrewsayre andrewsayre merged commit 2efc1de into home-assistant:dev May 5, 2019

14 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 97b5a38...f1481a3
Details
codecov/project 93.9% (target 90%)
Details
home-assistant Build #20190504.36 succeeded
Details
@Swiftnesses

This comment has been minimized.

Copy link

commented May 9, 2019

@amelchio Something funky is going on since this was implemented... I use a flow which does:

snapshot, stop, unjoin, join, announce, wait, restore.

It now cuts off 1 second into the announce, I can reproduce this easily by making a simple flow with:

snapshot, join, announce.... the announce is always cut off.

@andrewsayre

This comment has been minimized.

Copy link
Member

commented May 9, 2019

@Swiftnesses Please open an issue -- we can't track problems on merged PRs.

@home-assistant home-assistant locked as resolved and limited conversation to collaborators May 9, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.