Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
HomeKit Controller: Adopt config entries for pairing with homekit accessories #23825
As promised, here is a PR to switch HomeKit controller over to use config entries, which i'm hoping is ready for 0.94. (If this PR is ready before 0.93 leaves beta, please don't cherry pick it into 0.93. We are waiting for 0.94).
I am aware of #23802 and that i'll potentially need to rebase if that is merged first.
The config flows themselves were already added a few releases ago, this adds the
There is currently no configuration.yaml stuff for HomeKit controller so we don't try to preserve the old
We have pretty high test coverage (on the tip of my dev branch which has a few extras its >98% for all modules) for config flow and the entities in general - we just have to update common and all the tests carry on working with the new code.
This doesn't add device registry stuff, but I already have a branch lined up with device registry support ready to go after this.
Also, after this is merged I can also remove homekit_controller from
@MartinHjelmare sorry to tag you directly, but you've had some really good feedback for me before and as this is probably the biggest change i've submitted I was hoping I could trouble you for some here as well
If the code communicates with devices, web services, or third-party tools:
If the code does not interact with devices:
I need to check but I think everything is 97/98 including config flow after this. I have a commit kicking around my patch queue to take hk controller completely out of coveragerc. On a train atm but will post coverage summary later - can put coveragerc change in this PR if you like?
Here is the current summary - 100% for config flow.
Have cherry picked the commit to remove us from .coveragerc.