Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geniushub sensors for issues #23976

Merged
merged 2 commits into from May 21, 2019
Merged

Add geniushub sensors for issues #23976

merged 2 commits into from May 21, 2019

Conversation

zxdavb
Copy link
Contributor

@zxdavb zxdavb commented May 18, 2019

Breaking Change:

None

Description:

Add sensors for issues ([error, warning, info]). Count of issues is state, and array of issue is device_state_attributes.

Related issue (if applicable): None

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9492

Example entry for configuration.yaml (if applicable):

No changes.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works - N/A

@zxdavb
Copy link
Contributor Author

zxdavb commented May 18, 2019

@MartinHjelmare Hey this is a very simple PR. Could you take a look?

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged when comment is addressed and build passes.

homeassistant/components/geniushub/sensor.py Outdated Show resolved Hide resolved
@cgarwood cgarwood merged commit fbd7c72 into home-assistant:dev May 21, 2019
@zxdavb zxdavb deleted the add_geniushub_issue_sensors branch May 26, 2019 09:31
@balloob balloob mentioned this pull request Jun 4, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
* Inital commit

* delint - use new string formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants