Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trådfri component to use new zeroconf discovery #24041

Merged
merged 8 commits into from May 29, 2019

Conversation

Projects
None yet
3 participants
@Kane610
Copy link
Contributor

commented May 22, 2019

Description:

Related issue (if applicable): fixes home-assistant/architecture#198 (comment)
home-assistant/home-assistant.io#9506

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@codeowners-notifier

This comment has been minimized.

Copy link

commented May 22, 2019

Hey there @ggravlingen, mind taking a look at this pull request as its been labeled with a integration (tradfri) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@Kane610 Kane610 force-pushed the Kane610:zeroconf-discovery-tradfri branch from 5ac7c7a to 95d77d7 May 24, 2019

Kane610 and others added some commits May 22, 2019

@balloob balloob merged commit 3fef9a9 into home-assistant:dev May 29, 2019

2 of 3 checks passed

ci/circleci: static-check Your tests are queued behind your running builds
Details
build Workflow: build
Details
cla-bot Everyone involved has signed the CLA

@Kane610 Kane610 deleted the Kane610:zeroconf-discovery-tradfri branch May 29, 2019

@balloob balloob referenced this pull request Jun 4, 2019

Merged

0.94.0 #24305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.