Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate passing loop to DSMR #24127

Merged
merged 2 commits into from May 29, 2019

Conversation

Projects
None yet
3 participants
@balloob
Copy link
Member

commented May 26, 2019

Description:

loop is optional for create_dsmr_reader but looks like they don't call asyncio.get_event_loop() if it's None, and instead pass the loop variable on as-is. So make sure we pass a correct loop in.

Reverts a change from #23984 noticed by @WoLpH in #23984 (comment)

@balloob balloob referenced this pull request May 26, 2019

Merged

Don't pass in loop #23984

0 of 9 tasks complete
@WoLpH

This comment has been minimized.

Copy link
Contributor

commented May 26, 2019

I think it needs to be replaced both here and in the if. Or at the partial a few lines down.

@WoLpH

This comment has been minimized.

Copy link
Contributor

commented May 26, 2019

I've also created an issue upstream for this to be fixed. Once that gets updated I'll create a pull request here as well.

ndokter/dsmr_parser#36

@balloob

This comment has been minimized.

Copy link
Member Author

commented May 26, 2019

Done.

Interestingly, that was not one that I removed to begin with, so I guess it never worked 🤔

@balloob balloob merged commit 4b256f3 into dev May 29, 2019

14 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 96b7bb6...f096956
Details
codecov/project 94.15% (target 90%)
Details
home-assistant Build #20190526.39 succeeded
Details

@delete-merged-branch delete-merged-branch bot deleted the dsmr-loop branch May 29, 2019

@balloob balloob referenced this pull request Jun 4, 2019

Merged

0.94.0 #24305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.