Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic panels #24184

Merged
merged 2 commits into from May 30, 2019

Conversation

Projects
None yet
3 participants
@balloob
Copy link
Member

commented May 30, 2019

Breaking Change

Developers only: hass.components.frontend.async_register_built_in_panel is no longer an async function.

Description:

  • Allow removing panels from the frontend on the fly
  • Fire an event when panels are added/removed so the frontend knows when to reload

Successor of #23175

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from pvizeli May 30, 2019

@balloob balloob requested a review from home-assistant/core as a code owner May 30, 2019

@balloob balloob referenced this pull request May 30, 2019

Merged

Dynamic update panels #3227

@balloob balloob force-pushed the dynamic-panels branch from 9030349 to c47cd38 May 30, 2019

@pvizeli
Copy link
Member

left a comment

nice!

@pvizeli pvizeli merged commit 1a3a38d into dev May 30, 2019

13 of 14 checks passed

codecov/patch 50% of diff hit (target 94.17%)
Details
build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/project 94.16% (target 90%)
Details
home-assistant Build #20190530.5 succeeded
Details

@delete-merged-branch delete-merged-branch bot deleted the dynamic-panels branch May 30, 2019

@pvizeli pvizeli added this to the 0.94.0 milestone May 30, 2019

balloob added a commit that referenced this pull request May 30, 2019

Dynamic panels (#24184)
* Don't require all panel urls to be registered

* Allow removing panels, fire event when panels updated

@balloob balloob referenced this pull request Jun 4, 2019

Merged

0.94.0 #24305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.