Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homekit_controller: don't throw on routine transient encryption errors #24193

Merged

Conversation

Projects
None yet
3 participants
@Jc2k
Copy link
Contributor

commented May 30, 2019

Description:

After this change homekt_controller will catch EncryptionError errors and won't fill the logs with them. These are transient and happen when a device closes its TCP connection on us abruptly. They are harmless but can be blamed when debugging other issues.

There is already a test that the code recovers from an EncryptionError.

Can this go in 0.94?

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
homekit_controller no longer logs with transient network errors causi…
…ng crypto failures as it will auto recover

@balloob balloob added this to the 0.94.0 milestone May 30, 2019

@balloob balloob merged commit bcee3f9 into home-assistant:dev May 30, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 1a3a38d...e4ce4f1
Details
codecov/project 94.2% (target 90%)
Details

balloob added a commit that referenced this pull request May 30, 2019

homekit_controller no longer logs with transient network errors causi…
…ng crypto failures as it will auto recover (#24193)

@balloob balloob referenced this pull request Jun 4, 2019

Merged

0.94.0 #24305

@Jc2k Jc2k deleted the Jc2k:homekit_controller_transient_errors branch Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.