Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a discovery config flow to Wemo #24208

Merged
merged 1 commit into from Jun 3, 2019

Conversation

Projects
None yet
4 participants
@balloob
Copy link
Member

commented May 30, 2019

Description:

Convert Wemo to use config flows and make it discoverable via SSDP integration. I have not touched the rest of the integration, which still uses discovery forwarding. That's for the future.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If the code communicates with devices, web services, or third-party tools:

  • [The manifest file][manifest-docs] has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@codeowners-notifier

This comment has been minimized.

Copy link

commented May 30, 2019

Hey there @sqldiablo, mind taking a look at this pull request as its been labeled with a integration (wemo) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@balloob balloob force-pushed the wemo-config-flow branch from 9c55dd3 to 9492370 Jun 3, 2019

@balloob balloob merged commit 4c88578 into dev Jun 3, 2019

11 of 12 checks passed

ci/circleci: test 3.5.5 CircleCI is running your tests
Details
build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
home-assistant Build #20190603.34 succeeded
Details

@delete-merged-branch delete-merged-branch bot deleted the wemo-config-flow branch Jun 3, 2019

@balloob balloob added this to the 0.94.1 milestone Jun 8, 2019

balloob added a commit that referenced this pull request Jun 8, 2019

@balloob balloob referenced this pull request Jun 8, 2019

Merged

0.94.1 #24396

@DavidFW1960

This comment has been minimized.

Copy link

commented Jun 8, 2019

The integration for this shows as:
image
and no devices.
Changed my Wemo config to just:

wemo:

Is this expected behaviour?

@balloob

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2019

Ah the translations are not there yet :( will be fixed in 95.

Devices are indeed not there, that would require some more restructuring of the Wemo integration.

@scottsuine

This comment has been minimized.

Copy link

commented Jun 12, 2019

This seemed to break the discovery of Tasmota Sonoff devices that are in Wemo mode. Worked fine up to 0.93, since 0.94 these devices are no longer discoverable by Hassio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.