Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESPHome config flow with invalid config entry #24213

Conversation

Projects
None yet
3 participants
@OttoWinter
Copy link
Member

commented May 31, 2019

Description:

Reported by @VDRainer in #beta discord chat.

This happens when there's a config entry that never connected to the node - I'm not sure how such a state is possible unless some .storage files were messed with or the node was disconnected right after the config flow was ready.

Anyway, this patch stops other config flows from crashing in that case.

Depending on the cherry pick strategy option this can result in a failed cherry pick - best choose theirs as strategy option.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
@pvizeli

This comment has been minimized.

Copy link
Member

commented May 31, 2019

You can cherry-pick it self to rc

@OttoWinter

This comment has been minimized.

Copy link
Member Author

commented May 31, 2019

@pvizeli Ok, will do that after the PR is merged, thanks!

@pvizeli pvizeli merged commit 5610541 into home-assistant:dev May 31, 2019

14 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.21%)
Details
codecov/project 94.21% (target 90%)
Details
home-assistant Build #20190531.9 succeeded
Details

OttoWinter added a commit that referenced this pull request May 31, 2019

@OttoWinter

This comment has been minimized.

Copy link
Member Author

commented May 31, 2019

Ok, successfully cherry picked it into rc - I removed the PR from the milestone because it's already cherry-picked.

@OttoWinter OttoWinter removed this from the 0.94.0 milestone May 31, 2019

@balloob balloob referenced this pull request Jun 4, 2019

Merged

0.94.0 #24305

@balloob balloob referenced this pull request Jun 26, 2019

Merged

0.95.0 #24776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.