Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds AdGuard Home integration #24219

Merged
merged 11 commits into from Jun 2, 2019

Conversation

@frenck
Copy link
Member

commented May 31, 2019

Description:

Add new integration with AdGuard Home.

image

Setup integration:

image

Device support:

image

Auto-discovery for the AdGuard Home add-on:

image

image

Services:

image

Related issue (if applicable): n/a

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9538

Pull request with the Hass.io Supervisor (if applicable): home-assistant/hassio#1107

Pull request with the Hass.io Add-on (if applicable): hassio-addons/addon-adguard-home#15

Example entry for configuration.yaml (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
.coveragerc Outdated Show resolved Hide resolved

frenck added some commits May 31, 2019

@frenck frenck referenced this pull request May 31, 2019
2 of 2 tasks complete

@frenck frenck removed the docs-missing label May 31, 2019

@frenck frenck marked this pull request as ready for review May 31, 2019

@frenck frenck self-assigned this May 31, 2019

frenck added some commits May 31, 2019

"""Turn on the switch."""
from adguardhome import AdGuardHomeError

try:

This comment has been minimized.

Copy link
@balloob

balloob Jun 1, 2019

Member

FYI, this could have also been achieved via a decorator.

This comment has been minimized.

Copy link
@frenck

frenck Jun 1, 2019

Author Member

Aah true! Thanks, will improve on that.

This comment has been minimized.

Copy link
@frenck

frenck Jun 1, 2019

Author Member

Took a second look. It would save me 3 lines of code in 2 files (so 6). Not taking into account the creation and adding the decorator itself.

The price to pay is another level of "complexity" / code jump, which IMHO, in this case (saving is low) just harms the readability of the code.

While I do appreciate the suggestion, I would like to pass on this.

@balloob

balloob approved these changes Jun 1, 2019

Copy link
Member

left a comment

🎉

Ok to merge when the non-FYI comments have been addressed.

frenck added some commits Jun 1, 2019

@balloob balloob merged commit 9220270 into dev Jun 2, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.21%)
Details
codecov/project 94.22% (target 90%)
Details

@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0049 branch Jun 2, 2019

@balloob balloob removed the new-platform label Jun 25, 2019

@balloob balloob referenced this pull request Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.