Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use resource for index routing #24223

Merged
merged 1 commit into from May 31, 2019

Conversation

Projects
None yet
3 participants
@balloob
Copy link
Member

commented May 31, 2019

Description:

When I migrated how we routed the index page, I did not foresee custom integrations registering extra static paths. Oh boy was I wrong ;-) I broke the custom card updater. This fixes it.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@codeowners-notifier

This comment has been minimized.

Copy link

commented May 31, 2019

Hey there @home-assistant/frontend, mind taking a look at this pull request as its been labeled with a integration (frontend) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@pvizeli
Copy link
Member

left a comment

LGTM

@balloob balloob merged commit 3a0616c into dev May 31, 2019

14 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 5fa66ba...cb81f60
Details
codecov/project 94.2% (target 90%)
Details
home-assistant Build #20190531.24 succeeded
Details

@delete-merged-branch delete-merged-branch bot deleted the better-index-routing branch May 31, 2019

balloob added a commit that referenced this pull request May 31, 2019

@balloob balloob referenced this pull request Jun 4, 2019

Merged

0.94.0 #24305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.