Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifest support for homekit discovery #24225

Merged
merged 3 commits into from May 31, 2019

Conversation

@balloob
Copy link
Member

commented May 31, 2019

Description:

  • Make HomeKit discovery part of manifests and the zeroconf integration. This allows for better discovery and allows to reduce duplicate discoveries if a native integration can handle it and Homekit controller can.
  • Add support to the discovery flow to support HomeKit
  • Add support to LIFX to be discovered via Homekit

Related issue (if applicable): fixes home-assistant/architecture#248

Pull request with documentation for home-assistant.io (if applicable): home-assistant/developers.home-assistant#267

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@codeowners-notifier

This comment has been minimized.

Copy link

commented May 31, 2019

Hey there @amelchio, mind taking a look at this pull request as its been labeled with a integration (lifx) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@codeowners-notifier

This comment has been minimized.

Copy link

commented May 31, 2019

Hey there @robbiet480, @Kane610, mind taking a look at this pull request as its been labeled with a integration (zeroconf) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@balloob balloob added this to the 0.94.0 milestone May 31, 2019

@balloob balloob referenced this pull request May 31, 2019

Merged

Add HomeKit discovery docs #267

@Kane610
Copy link
Contributor

left a comment

Looks good to me

@balloob balloob merged commit 3c1cdec into dev May 31, 2019

11 of 12 checks passed

ci/circleci: test 3.5.5 CircleCI is running your tests
Details
build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
home-assistant Build #20190531.31 succeeded
Details

@delete-merged-branch delete-merged-branch bot deleted the zeroconf-homekit branch May 31, 2019

balloob added a commit that referenced this pull request May 31, 2019

Add manifest support for homekit discovery (#24225)
* Add manifest support for homekit discovery

* Add a space after model check

* Update comment
@Jc2k

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2019

Nice 👍

@balloob balloob referenced this pull request Jun 4, 2019

Merged

0.94.0 #24305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.