Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log HomeKit model #24229

Merged
merged 1 commit into from Jun 1, 2019

Conversation

Projects
None yet
3 participants
@balloob
Copy link
Member

commented May 31, 2019

Description:

Add some extra logging so we can easier get people to help us find the correct HomeKit models to include in our manifests.

@codeowners-notifier

This comment has been minimized.

Copy link

commented May 31, 2019

Hey there @Jc2k, mind taking a look at this pull request as its been labeled with a integration (homekit_controller) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@balloob balloob merged commit 70fe4f2 into dev Jun 1, 2019

14 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.21%)
Details
codecov/project 94.21% (target 90%)
Details
home-assistant Build #20190531.38 succeeded
Details

@delete-merged-branch delete-merged-branch bot deleted the log-homekit-model branch Jun 1, 2019

balloob added a commit that referenced this pull request Jun 1, 2019

@Jc2k

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2019

LGTM 👍

@balloob balloob referenced this pull request Jun 4, 2019

Merged

0.94.0 #24305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.