Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPSLogger device_info and unique_id #24231

Merged
merged 1 commit into from Jun 1, 2019

Conversation

Projects
None yet
2 participants
@balloob
Copy link
Member

commented May 31, 2019

Description:

When we migrated 4 device tracker platforms to use config entries and entity base class, we didn't give them a unique ID and device info, which made it so that users are unable to change the name/entity_id, and so are losing some functionality compared to known_devices.yaml (which no longer works for these).

Checklist:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.94.0 milestone May 31, 2019

@balloob balloob merged commit 3edc58a into dev Jun 1, 2019

13 checks passed

build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.21%)
Details
codecov/project 94.21% (target 90%)
Details

@delete-merged-branch delete-merged-branch bot deleted the gpslogger branch Jun 1, 2019

balloob added a commit that referenced this pull request Jun 1, 2019

@balloob balloob referenced this pull request Jun 4, 2019

Merged

0.94.0 #24305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.