Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a deprecation warning for tplink device_tracker #24236

Merged
merged 2 commits into from Jun 1, 2019

Conversation

Projects
None yet
3 participants
@rytilahti
Copy link
Contributor

commented Jun 1, 2019

Description:

As discussed on discord, this PR will add a warning to tplink's (misplaced) device_tracker platform in hope of getting someone to convert it to a separate integration separate from unrelated tplink smarthome integration (my proposal would be tplink_router).

I'm adding several related issues/PRs to raise awareness (again, hoping that someone will pick up the maintainership) of those who have reported/worked on this platform before.

Related issue (if applicable): #24091 #14641 #20769 #24140 #13991 #11827 #10575 #17371 #14801 #13525 #10506

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@balloob

balloob approved these changes Jun 1, 2019

@balloob balloob added this to the 0.94.0 milestone Jun 1, 2019

@balloob balloob merged commit 3076866 into home-assistant:dev Jun 1, 2019

13 of 14 checks passed

home-assistant
Details
build Workflow: build
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: pylint Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 9f1dc71...c1e9e0b
Details
codecov/project 94.21% (target 90%)
Details

balloob added a commit that referenced this pull request Jun 1, 2019

add a deprecation warning for tplink device_tracker (#24236)
* add a deprecation warning for tplink device_tracker

* reword the warning a bit

@rytilahti rytilahti deleted the rytilahti:deprecate_tplink_tracker branch Jun 1, 2019

@balloob balloob referenced this pull request Jun 4, 2019

Merged

0.94.0 #24305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.