add a deprecation warning for tplink device_tracker #24236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: tplink
small-pr
ghost
assigned 
balloob
approved these changes
Jun 1, 2019
balloob
pushed a commit
that referenced
this pull request
Jun 1, 2019
* add a deprecation warning for tplink device_tracker * reword the warning a bit
Merged
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Oct 12, 2019
…4236) * add a deprecation warning for tplink device_tracker * reword the warning a bit
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As discussed on discord, this PR will add a warning to tplink's (misplaced) device_tracker platform in hope of getting someone to convert it to a separate integration separate from unrelated tplink smarthome integration (my proposal would be
tplink_router).I'm adding several related issues/PRs to raise awareness (again, hoping that someone will pick up the maintainership) of those who have reported/worked on this platform before.
Related issue (if applicable): #24091 #14641 #20769 #24140 #13991 #11827 #10575 #17371 #14801 #13525 #10506
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: