Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update home zone when core config updated #24237

Merged
merged 2 commits into from Jun 1, 2019

Conversation

Projects
None yet
2 participants
@balloob
Copy link
Member

commented Jun 1, 2019

Description:

Update the home zone whenever the core config is updated. Also renamed the update method to async_update to match our naming convention.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@codeowners-notifier

This comment has been minimized.

Copy link

commented Jun 1, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (zone) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@codeowners-notifier

This comment has been minimized.

Copy link

commented Jun 1, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (config) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@balloob balloob merged commit b90636f into dev Jun 1, 2019

7 of 12 checks passed

build Workflow: build
Details
home-assistant
Details
ci/circleci: pylint CircleCI is running your tests
Details
ci/circleci: test 3.5.5 CircleCI is running your tests
Details
ci/circleci: test 3.6 Your tests are queued behind your running builds
Details
ci/circleci: pre-install-all-requirements Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.5.5 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.6 Your tests passed on CircleCI!
Details
ci/circleci: pre-test 3.7 Your tests passed on CircleCI!
Details
ci/circleci: static-check Your tests passed on CircleCI!
Details
ci/circleci: test 3.7 Your tests passed on CircleCI!
Details
cla-bot Everyone involved has signed the CLA

@delete-merged-branch delete-merged-branch bot deleted the update-home-zone branch Jun 1, 2019

@balloob balloob added this to the 0.94.2 milestone Jun 11, 2019

balloob added a commit that referenced this pull request Jun 11, 2019

Update home zone when core config updated (#24237)
* Update home zone when core config updated

* Lint

@balloob balloob referenced this pull request Jun 11, 2019

Merged

0.94.2 #24465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.